Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ip / IMP color codes for plotting #794

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Conversation

byersiiasa
Copy link
Collaborator

@byersiiasa byersiiasa commented Nov 1, 2023

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Description of PR

This PR fixed wrong color codes for AR6 Illustrative Pathways

@byersiiasa byersiiasa marked this pull request as ready for review November 1, 2023 00:31
@danielhuppmann
Copy link
Member

Not sure why @jkikstra added the wrong colors in #650...?

Anyway, I'll start a PR into your branch updating the test-plots so that the tests pass.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #794 (dd2f463) into main (5b2f3b6) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #794   +/-   ##
=====================================
  Coverage   94.7%   94.7%           
=====================================
  Files         62      62           
  Lines       5996    5996           
=====================================
  Hits        5681    5681           
  Misses       315     315           
Files Coverage Δ
pyam/plotting.py 92.9% <ø> (ø)

@jkikstra
Copy link
Collaborator

jkikstra commented Nov 3, 2023

Anyway, I'll start a PR into your branch updating the test-plots so that the tests pass.

@jkikstra also doesn't know! I assume I myself got the colours from @byersiiasa, so maybe I myself had an old version (e.g. SOD)?

Copy link
Collaborator

@jkikstra jkikstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked a few against AR6 WG3 SPM, the new colours look correct to me.

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielhuppmann danielhuppmann merged commit 3eda7e5 into main Nov 3, 2023
12 checks passed
@danielhuppmann danielhuppmann deleted the fix_imp_colors branch November 3, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants