Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise explicit error message if no connection to IIASA manager service #796

Merged

Conversation

danielhuppmann
Copy link
Member

Description of PR

This PR fixes an ixmp4-integration issue where an AttributeError is raised (instead of a ConnectError) if the connection to the IIASA ScSe manager service cannot be established.

@danielhuppmann danielhuppmann self-assigned this Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #796 (2caf42c) into main (3eda7e5) will decrease coverage by 0.1%.
The diff coverage is 66.6%.

@@           Coverage Diff           @@
##            main    #796     +/-   ##
=======================================
- Coverage   94.7%   94.7%   -0.1%     
=======================================
  Files         62      62             
  Lines       5996    5999      +3     
=======================================
+ Hits        5681    5683      +2     
- Misses       315     316      +1     
Files Coverage Δ
pyam/iiasa.py 89.5% <66.6%> (-0.3%) ⬇️

@danielhuppmann danielhuppmann marked this pull request as ready for review November 3, 2023 07:49
@danielhuppmann danielhuppmann merged commit ce538ae into IAMconsortium:main Nov 3, 2023
11 checks passed
@danielhuppmann danielhuppmann deleted the devops/tests-offline branch November 3, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant