Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor validate module, make slice a keyword-only method #802

Merged

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Dec 4, 2023

Description of PR

This PR refactors the validation-utility and moves them to its own module in preparation for a larger feature update.

@danielhuppmann danielhuppmann self-assigned this Dec 4, 2023
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6583339) 94.7% compared to head (d699ac5) 94.7%.

Files Patch % Lines
pyam/validation.py 93.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #802     +/-   ##
=======================================
- Coverage   94.7%   94.7%   -0.1%     
=======================================
  Files         62      62             
  Lines       6013    6012      -1     
=======================================
- Hits        5697    5696      -1     
  Misses       316     316             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielhuppmann danielhuppmann marked this pull request as ready for review December 9, 2023 14:06
@danielhuppmann danielhuppmann merged commit d1cd1f7 into IAMconsortium:main Dec 9, 2023
11 checks passed
@danielhuppmann danielhuppmann deleted the devops/validate-module branch December 9, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant