Extend the validate() signature
#804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
=====================================
Coverage 94.7% 94.7%
=====================================
Files 62 62
Lines 6012 6058 +46
=====================================
+ Hits 5696 5741 +45
- Misses 316 317 +1 ☔ View full report in Codecov by Sentry. |
phackstock
approved these changes
Dec 11, 2023
| pdt.assert_frame_equal(obs, test_df.data[5:6].reset_index(drop=True)) | ||
| assert list(test_df.exclude) == [False, True] | ||
|
|
||
|
|
||
| def test_validate_multiple_criteria(test_df): |
There was a problem hiding this comment.
You could assert here in addition that the deprecation warning is issued.
| "Use `upper`, `lower`, and filter-arguments instead.", "Argument `criteria`" | ||
| ) | ||
| if upper or lower is not None and not kwargs.empty: | ||
| raise NotImplementedError( |
There was a problem hiding this comment.
Seems that Codecov and I came to the same conclusion here :D
|
Thanks @phackstock - implemented your suggestion for |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Name of contributors Added to AUTHORS.rstDescription of PR
This PR extends the signature of the
validate()method to take filter-arguments directly instead of using a (nested) dictionary, socan now be called as
This allows to validate only a selection of the datapoints, e.g., filtered by region or model/scenario name. The signature can also more easily be called from a (to-be-implemented) processor in the nomenclature package.
The option to use nested dicts is marked as deprecated with release 3.0.