Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read_ixmp4() method and extend integration test #826

Merged

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Mar 1, 2024

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Description of PR

This PR adds an initial read_ixmp4() function to query data from an ixmp4 platform. Note that this function currently only allows to get all IAMC-timeseries data and meta indicators for all scenarios or only default scenarios. More elaborate filters will be added in a subsequent step.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 97.36842% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 94.8%. Comparing base (350d57a) to head (c2cf7a5).

Files Patch % Lines
pyam/ixmp4.py 93.3% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #826   +/-   ##
=====================================
  Coverage   94.8%   94.8%           
=====================================
  Files         64      64           
  Lines       6092    6125   +33     
=====================================
+ Hits        5778    5810   +32     
- Misses       314     315    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@phackstock phackstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just a few minor comments in line.

pyam/ixmp4.py Outdated Show resolved Hide resolved
tests/test_ixmp4.py Outdated Show resolved Hide resolved
tests/test_ixmp4.py Show resolved Hide resolved
@danielhuppmann danielhuppmann merged commit 1ceeeeb into IAMconsortium:main Mar 1, 2024
14 checks passed
@danielhuppmann danielhuppmann deleted the ixmp4/read-platform branch March 1, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants