Add test-platform fixture for ixmp4 tests
#832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
=======================================
+ Coverage 95.0% 95.1% +0.1%
=======================================
Files 64 63 -1
Lines 6134 6148 +14
=======================================
+ Hits 5828 5849 +21
+ Misses 306 299 -7 ☔ View full report in Codecov by Sentry. |
phackstock
approved these changes
Mar 7, 2024
| logger.warning( | ||
| "The `meta.version` column was dropped when writing to the ixmp4 platform." | ||
| ) | ||
| meta = df.meta.drop(columns="version") |
There was a problem hiding this comment.
Could this result in an empty data frame except for the model and scenario index?
There was a problem hiding this comment.
yes, added a test-variant for this case
tests/test_ixmp4.py
Outdated
| test_df_year.set_meta(1, "version") # add version number added from ixmp4 | ||
| test_df_year.to_ixmp4(platform=test_platform) | ||
|
|
||
| assert "version" not in test_platform.runs.get("model_a", "scen_a").meta |
There was a problem hiding this comment.
Would the meta here just yield nothing?
There was a problem hiding this comment.
meta yields an empty dictionary here, added a test for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Documentation AddedName of contributors Added to AUTHORS.rstDescription of PR
This PR implements a few improvements related to the tests of the ixmp4-integration:
test_platformfixture in conftest