-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to poetry groups instead of extras #833
Changes from 6 commits
f254e74
221866a
1cf4ebe
3deeabd
deadad6
cf75d2e
17b617d
4ca5641
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,7 +51,7 @@ jobs: | |
# update dependencies to latest versions | ||
#------------------------------------------ | ||
- name: Update dependencies | ||
run: poetry update --lock | ||
run: poetry update dev,docs,optional_io_formats,optional_plotting,tutorials,wbdata --lock | ||
|
||
#------------------------------------ | ||
# load cached venv if cache exists | ||
|
@@ -68,13 +68,13 @@ jobs: | |
#------------------------------------------------ | ||
- name: Install dependencies | ||
if: steps.cached-poetry-dependencies.outputs.cache-hit != 'true' | ||
run: poetry install --no-interaction --extras "docs optional_io_formats optional_plotting tests tutorials" --no-root | ||
run: poetry install --no-interaction --with dev,docs,optional_io_formats,optional_plotting,tutorials,wbdata --no-root | ||
|
||
#------------------------ | ||
# install root project | ||
#------------------------ | ||
- name: Install library | ||
run: poetry install --no-interaction --extras "optional_io_formats optional_plotting tests tutorials" --only-root | ||
run: poetry install --no-interaction --with dev,optional_io_formats,optional_plotting,tutorials,wbdata | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is there any specific reason to remove There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
|
||
- name: Test with pytest (including Matplotlib) | ||
run: poetry run pytest tests --mpl | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,13 +60,13 @@ jobs: | |
#------------------------------------------------ | ||
- name: Install dependencies | ||
if: steps.cached-poetry-dependencies.outputs.cache-hit != 'true' | ||
run: poetry install --no-interaction --extras "optional_io_formats optional_plotting tests tutorials" --no-root | ||
run: poetry install --no-interaction --with dev,optional_io_formats,optional_plotting,tutorials --no-root | ||
|
||
#------------------------ | ||
# install root project | ||
#------------------------ | ||
- name: Install library | ||
run: poetry install --no-interaction --extras "optional_io_formats optional_plotting tests tutorials" --only-root | ||
run: poetry install --no-interaction --with dev,optional_io_formats,optional_plotting,tutorials | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as in nightly workflow. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
|
||
- name: Test with pytest | ||
run: poetry run pytest tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These white spaces seem unnecessary, but not too tragic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the whitespaces