Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to filter by measurand #868

Merged
merged 10 commits into from
Aug 5, 2024

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Jul 26, 2024

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Description of PR

This PR adds a feature to support filtering by a "measurand", i.e., a tuple (or iterable of tuples) of variable and unit

See the related discussion at IAMconsortium/nomenclature#360

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.0%. Comparing base (ddbb88e) to head (fd5338e).
Report is 25 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #868   +/-   ##
=====================================
  Coverage   95.0%   95.0%           
=====================================
  Files         64      64           
  Lines       6134    6191   +57     
=====================================
+ Hits        5828    5884   +56     
- Misses       306     307    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielhuppmann danielhuppmann marked this pull request as ready for review July 26, 2024 14:53
Copy link
Contributor

@phackstock phackstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, after that good to merge.

tests/test_core.py Outdated Show resolved Hide resolved
tests/test_core.py Outdated Show resolved Hide resolved
tests/test_core.py Outdated Show resolved Hide resolved
@danielhuppmann danielhuppmann merged commit 9e2117e into IAMconsortium:main Aug 5, 2024
14 checks passed
@danielhuppmann danielhuppmann deleted the filter/measurand branch August 5, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants