-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance improvements for formatPath #194
Merged
Merged
+228
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kramvan1
reviewed
Jan 22, 2025
kramvan1
reviewed
Jan 22, 2025
…tests for that in formatPath Adds the original implementation of formatPath for comparison in tests and benchmarks
jcopi
commented
Jan 25, 2025
jcopi
commented
Jan 25, 2025
Benchmark Results
|
kramvan1
reviewed
Jan 27, 2025
kramvan1
reviewed
Jan 27, 2025
kramvan1
reviewed
Jan 27, 2025
kramvan1
reviewed
Jan 28, 2025
kramvan1
reviewed
Jan 28, 2025
@jcopi Thx for all your work here. We would like to get this in now. I added a few last minor updates and then can create the formal PR for finals reviews. |
kramvan1
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change reduces memory usage of the
formatPath
function by:Grow
after creating astrings.Builder
to reduce the number of future allocationsstrings.Split
, instead if iterates over the segments usingstrings.Cut
so that there is no need to allocate a string header per path segment.Attributes
so that theGetAttribute
function returns(string, bool)
rather than*string
. This eliminates the need for a heap allocation of the attribute value in most cases.The result of this is that formatPath is faster and has a single allocation (assuming the formatted string is <= 2x the length of the pattern).
This also adds benchmarks and tests for the the
formatPath
function to ensure that functionality has not changedENSURE THE FOLLOWING ARE MET:
Below is a brief summary of PR requirements (full list).
By opening this PR for review, the author has agreed that these criteria must be met.
By approving this PR, the reviewers have also agreed these criteria have been met and it is ready to be merged.