resilence 409 and update docs to include force_delete flag and force_… #4841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…delete=true in examples
| @@ -49,6 +50,7 @@ Review the argument references that you can specify for your resource. | |||
| - `endpoint_type` - (Optional, Forces new resource, String) The type of the public endpoint, or private endpoint to be used for creating keys. | |||
| - `instance_id` - (Required, Forces new resource, String) The hs-crypto or key protect instance GUID. | |||
| - `key_ring_id` - (Required, Forces new resource, String) The ID that identifies the key ring. Each ID is unique within the given instance and is not reserved across the key protect service. **Constraints** `2 ≤ length ≤ 100`. Value must match regular expression of `^[a-zA-Z0-9-]*$`. | |||
| - `force_delete` - (Optional, Bool) If set to **true**, allows force deletion of a key ring. Terraform users are recommended to have this set to **true**. All keys in the key ring are required to be deleted (in state **5**) before this action can be performed. If the key ring to be deleted contains keys, they will be moved to the **default** key ring which requires the **kms.secrets.patch** IAM action. | |||
There was a problem hiding this comment.
suggestion:
(Optional, Bool) If set to true, allows force deletion of a key ring. Terraform users are recommended to have this set to true. All keys in the key ring are required to be destroyed (in state 5) before this action can be performed. If the key ring to be deleted contains keys, they will be moved to the default key ring which requires the kms.secrets.patch IAM action.
There was a problem hiding this comment.
I think this is right. I could do it in a separate PR if we think it is important enough
There was a problem hiding this comment.
Sorry, this looks good. I misread your initial code.
hkantare
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…delete=true in examples
Community Note
Relates OR Closes #0000
Output from acceptance testing: