Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dhcp and dhcps data source and documentation #5056

Merged
merged 17 commits into from
Mar 5, 2024
Merged

Refactor dhcp and dhcps data source and documentation #5056

merged 17 commits into from
Mar 5, 2024

Conversation

Diptipowervs
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@ismirlia ismirlia added the service/Power Systems Issues related to Power Systems label Jan 18, 2024
@Diptipowervs
Copy link
Contributor Author

--- PASS: TestAccIBMPIDhcpDataSourceBasic (30.72s)
PASS

yussufsh
yussufsh requested changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the docs with merge conflict changes.

website/docs/d/pi_dhcp.html.markdown Outdated Show resolved Hide resolved
website/docs/d/pi_dhcp.html.markdown Outdated Show resolved Hide resolved
ibm/service/power/data_source_ibm_pi_dhcp.go Outdated Show resolved Hide resolved
website/docs/d/pi_dhcps.html.markdown Outdated Show resolved Hide resolved
website/docs/d/pi_dhcps.html.markdown Outdated Show resolved Hide resolved
@ismirlia ismirlia requested a review from yussufsh February 29, 2024 22:25
yussufsh
yussufsh requested changes Mar 1, 2024
View reviewed changes
ibm/service/power/data_source_ibm_pi_dhcp.go Outdated Show resolved Hide resolved
ibm/service/power/data_source_ibm_pi_dhcps.go Outdated Show resolved Hide resolved
website/docs/d/pi_dhcps.html.markdown Outdated Show resolved Hide resolved
website/docs/d/pi_dhcp.html.markdown Outdated Show resolved Hide resolved
@ismirlia
Copy link
Collaborator

ismirlia commented Mar 1, 2024

So to summarize the get for the dhcp has two fields pi_dhcp_id and dhcp_id which are the same, so redundant one dhcp_id can be deprecated.

The get all for the dhcp has no redundant fields because the set id is just a GUID?

@yussufsh

@ismirlia
Copy link
Collaborator

ismirlia commented Mar 1, 2024 

--- PASS: TestAccIBMPIDhcpDataSourceBasic (14.06s)
PASS

--- PASS: TestAccIBMPIDhcpServersDataSourceBasic (209.34s)
PASS

@hkantare hkantare merged commit 054d8c3 into IBM-Cloud:master Mar 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh requested changes

@hkantare hkantare hkantare approved these changes

@michaelkad michaelkad Awaiting requested review from michaelkad

@ismirlia ismirlia Awaiting requested review from ismirlia

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Diptipowervs @ismirlia @yussufsh @hkantare