Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor disaster recovery location data source and documentation #5057

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Refactor disaster recovery location data source and documentation #5057

merged 6 commits into from
Feb 16, 2024

Conversation

Diptipowervs
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@ismirlia ismirlia added the service/Power Systems Issues related to Power Systems label Jan 18, 2024
@Diptipowervs
Copy link
Contributor Author

--- PASS: TestAccIBMPIDisasterRecoveryLocationDataSourceBasic (37.02s)
PASS

michaelkad
michaelkad approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@michaelkad michaelkad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hkantare hkantare merged commit de54fd7 into IBM-Cloud:master Feb 16, 2024
1 check passed
@michaelkad michaelkad deleted the disaster-recovery-refactor branch May 28, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelkad michaelkad michaelkad approved these changes

@hkantare hkantare hkantare approved these changes

@yussufsh yussufsh Awaiting requested review from yussufsh

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Diptipowervs @hkantare @michaelkad @ismirlia