Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support empty lists for CBR rule contexts and zone addresses #5058

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

mtbrandy
Copy link
Contributor

@mtbrandy mtbrandy commented Jan 18, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIBMCbr'

=== RUN   TestAccIBMCbrRuleDataSourceBasic
--- PASS: TestAccIBMCbrRuleDataSourceBasic (14.90s)
=== RUN   TestAccIBMCbrRuleDataSourceAllArgs
--- PASS: TestAccIBMCbrRuleDataSourceAllArgs (11.43s)
=== RUN   TestAccIBMCbrZoneDataSourceBasic
--- PASS: TestAccIBMCbrZoneDataSourceBasic (11.58s)
=== RUN   TestAccIBMCbrZoneDataSourceAllArgs
--- PASS: TestAccIBMCbrZoneDataSourceAllArgs (10.80s)
=== RUN   TestAccIBMCbrRuleBasic
--- PASS: TestAccIBMCbrRuleBasic (8.89s)
=== RUN   TestAccIBMCbrRuleAllArgs
--- PASS: TestAccIBMCbrRuleAllArgs (19.86s)
=== RUN   TestAccIBMCbrZoneBasic
--- PASS: TestAccIBMCbrZoneBasic (9.38s)
=== RUN   TestAccIBMCbrZoneAllArgs
--- PASS: TestAccIBMCbrZoneAllArgs (19.46s)
PASS

@zhenwan
Copy link
Contributor

zhenwan commented Jan 18, 2024

It would be great if we could add examples to the following two files to demonstrate the new features:
website/docs/r/cbr_rule.html.markdown
website/docs/r/cbr_zone.html.markdown

@mtbrandy
Copy link
Contributor Author

It would be great if we could add examples to the following two files to demonstrate the new features: website/docs/r/cbr_rule.html.markdown website/docs/r/cbr_zone.html.markdown

Creating rules with empty context lists / zones with empty address lists is a fairly specific use case (not allowing any access). I don't think it should be included in the basic examples at this time.

@mtbrandy mtbrandy marked this pull request as ready for review January 25, 2024 00:10
@hkantare hkantare merged commit e332407 into IBM-Cloud:master Jan 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants