fix(Cloud-Databases): RR & PITR Groups Attribute is Fixed for Source Formations with Multiple Members

[omaraibrahim]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

Description

Read Replicas and PITRs are not working for formations with multiple members.

This is because our codebase assumes that the source formation will always have the default members. In the fix, we will now get the members from the source formation.

Example of Successful Read Replica with 3 members

resource "ibm_database" "postgresql" {
  resource_group_id            = data.ibm_resource_group.test_acc.id
  name                         = "omar-psql-12-12-us-east-pg-rr"
  service                      = "databases-for-postgresql"
  plan                         = "standard"
  location                     = "us-east"
  service_endpoints            = "public"
  version = "15"
  remote_leader_id = "crn:v1:bluemix:public:databases-for-postgresql:us-east:a/40ddc34a953a8c02f10987b59085b60e:d70adc01-434b-4482-a403-a43fa658dfce::"
  group {
    group_id = "member"
    cpu {
      allocation_count = 3
    }
    disk {
      allocation_mb = 30720
    }
    host_flavor {
      id = "multitenant"
    }
    memory {
      allocation_mb = 7168
    }
  }
}

Example of Successful Read Replica with 2 members

resource "ibm_database" "postgresql" {
  resource_group_id            = data.ibm_resource_group.test_acc.id
  name                         = "omar-psql-12-12-us-east-pg-rr-2"
  service                      = "databases-for-postgresql"
  plan                         = "standard"
  location                     = "us-east"
  service_endpoints            = "public"
  version = "16"
  remote_leader_id = "crn:v1:bluemix:public:databases-for-postgresql:us-east:a/40ddc34a953a8c02f10987b59085b60e:490d8e84-18b4-43f1-80c5-cd206406672a::"
  group {
    group_id = "member"
    cpu {
      allocation_count = 3
    }
    disk {
      allocation_mb = 30720
    }
    host_flavor {
      id = "multitenant"
    }
    memory {
      allocation_mb = 7168
    }
  }
}

Example of Successful PITR with 3 members

resource "ibm_database" "postgresql" {
  resource_group_id            = data.ibm_resource_group.test_acc.id
  name                         = "omar-psql-12-10-us-east-pg-pitr"
  service                      = "databases-for-postgresql"
  plan                         = "standard"
  location                     = "us-east"
  service_endpoints            = "public"
  version = "15"
  point_in_time_recovery_deployment_id = "crn:v1:bluemix:public:databases-for-postgresql:us-east:a/40ddc34a953a8c02f10987b59085b60e:d70adc01-434b-4482-a403-a43fa658dfce::"
  point_in_time_recovery_time = "2024-12-09T21:24:02.000Z"
  group {
    group_id = "member"
    cpu {
      allocation_count = 3
    }
    disk {
      allocation_mb = 30720
    }
    host_flavor {
      id = "multitenant"
    }
    memory {
      allocation_mb = 7168
    }
  }
}

Example of Successful PITR with 2 members

resource "ibm_database" "postgresql" {
  resource_group_id            = data.ibm_resource_group.test_acc.id
  name                         = "omar-psql-12-12-us-east-pg-pitr-2"
  service                      = "databases-for-postgresql"
  plan                         = "standard"
  location                     = "us-east"
  service_endpoints            = "public"
  version = "16"
  point_in_time_recovery_deployment_id = "crn:v1:bluemix:public:databases-for-postgresql:us-east:a/40ddc34a953a8c02f10987b59085b60e:490d8e84-18b4-43f1-80c5-cd206406672a::"
  point_in_time_recovery_time = "2024-12-12T14:46:07.000Z"
  group {
    group_id = "member"
    cpu {
      allocation_count = 2
    }
    disk {
      allocation_mb = 30720
    }
    host_flavor {
      id = "multitenant"
    }
    memory {
      allocation_mb = 7168
    }
  }
}

Acceptance Tests

make testacc TEST=./ibm/service/database TESTARGS='-run=TestAccIBMDatabaseInstance_Redis_Basic'
...
--- PASS: TestAccIBMDatabaseInstance_Redis_Basic (1409.12s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database	1410.850s

make testacc TEST=./ibm/service/database TESTARGS='-run=TestAccIBMDatabaseInstanceMongodbBasic'
...
--- PASS: TestAccIBMDatabaseInstanceMongodbBasic (1083.59s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database	1084.952s

make testacc TEST=./ibm/service/database TESTARGS='-run=TestAccIBMDatabaseInstance_ElasticsearchPlatinum_Basic'
...
--- PASS: TestAccIBMDatabaseInstance_ElasticsearchPlatinum_Basic (1742.79s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database	1744.144s

[alexhemard]

LGTM