Skip to content
This repository has been archived by the owner on Nov 4, 2022. It is now read-only.

Bar #55

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Bar #55

wants to merge 18 commits into from

Conversation

abbystarnes
Copy link
Collaborator

Changed

  • added styling to bar chart

@seejamescode
Copy link
Collaborator

Hey @abbystarnes, there are a bunch of line files in here. I believe this branch should only reflect master branch and that branch does not have a folder for the line chart yet.

@abbystarnes
Copy link
Collaborator Author

@seejamescode Thanks for catching that. Not sure how I added the line files, but I've removed them. I rewrote the bar chart based on the line chart so that they'd be in better alignment.

What can I do to pass Travis CI tests?

@seejamescode
Copy link
Collaborator

@abbystarnes Travis looks like it is failing on building the line chart. There is still a charts-line folder in your branch, but should not be. See if completely taking out references to the line chart helps!

@abbystarnes
Copy link
Collaborator Author

abbystarnes commented Mar 31, 2017

@seejamescode I've removed the line folder. Travis CI still seems to be getting stuck on variables that are declared in one file and used in another. (no-unused-vars and no-undef). Is there a work around for this?

@rodet
Copy link
Collaborator

rodet commented Apr 3, 2017

I'm taking a look at the build errors.

* Remove unneeded dist folders

* SCSS linter fixes

* Fix the compiling errors

- Remove extraneous file charts-bar.js and its reference in package.json
- Fix linter errors in ivm-charts-bar.js
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants