fail if interface script not exist and add prepend DNS to dhclient.co… #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nf if bastion is booting from DHCP.
|
@hughjfchen There are a lot of commits in this PR. Please let me know if your intention is to contribute to this repo or if you want to maintain a fork. |
|
@fketelaars Actually, I'm not very sure now. Firstly, I just want to fix some issues but I've added a lot of features which |
|
@hughjfchen Thanks for the quick response. I will close the PR for now. If you believe there are defects in the current repo that you could resolve. Can you please make separate changes for that and send a PR? Good luck with the fork! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nf if bastion is booting from DHCP.
Fix #36 #37