Update doc for doc_id and ededup to follow template in issue #753 #836
+546
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Constantin M Adam <[email protected]>
Signed-off-by: Constantin M Adam <[email protected]>
Signed-off-by: Constantin M Adam <[email protected]>
Signed-off-by: Constantin M Adam <[email protected]>
Signed-off-by: Constantin M Adam <[email protected]>
cmadam
changed the title
|
Thank you, @cmadam! Very nice job! I will read and review them carefully on Monday. |
shahrokhDaijavad
requested changes
Dec 2, 2024
There was a problem hiding this comment.
@cmadam The README files all look good to me. There is a section in both notebooks about "Configuring the transform parameters" (below the pip install cell) that has been copy/pasted from the DocQualityTransform and needs to be modified to describe the relevant parameters for doc_id and ededup (just like what you did in the notebooks for fdedup).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Provide uniform documentation, as mentioned in issue #753
Related issue number (if any).
Issue #753