Skip to content

Commit

Permalink
Merge branch 'IBM:master' into diff-branch
Browse files Browse the repository at this point in the history
  • Loading branch information
nickrayjones authored Dec 15, 2023
2 parents 0a98d29 + 58f54db commit 7e99e92
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Makefile.ibm
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ trivy-scan-python-vulnerabilities:
./scripts/gen-pipfile.sh > Pipfile
pipenv --python `which python3`
pipenv lock
$(TRIVY) fs --exit-code 1 --ignore-unfixed --security-checks vuln ./
$(TRIVY) fs --exit-code 1 --ignore-unfixed --scanners vuln ./

docker-quality-images:
for image_name in $(DOCKER_IMAGES_TO_SCAN) ; do \
Expand Down
4 changes: 2 additions & 2 deletions docs/developer-tool-faq.md
Original file line number Diff line number Diff line change
Expand Up @@ -419,11 +419,11 @@ The `detect-secrets` tool can also be run as a docker container. It supports Win

#### Prerequisite

You need to have Python and [install the pre-commit framework](https://pre-commit.com/#install). The docker image of `detect-secrets` saves you the effort of installing the detect-secret pip package, which would require a heavy weight compilation environment. Besides that, please also make sure you have [docker installed](https://docs.docker.com/install/).
You need to have Python and [install the pre-commit framework](https://pre-commit.com/#install). The docker image of `detect-secrets` saves you the effort of installing the detect-secret pip package, which would require a heavy weight compilation environment. Besides that, please also make sure you have a desktop container management application such as [Rancher Desktop](https://rancherdesktop.io) or [Podman Desktop](https://podman-desktop.io) installed. (NOTE: Docker Desktop is no longer approved to use on IBM devices.)

1. python [installed](https://docs.python-guide.org/starting/installation/)
1. pre-commit framework [installed](https://pre-commit.com/#install)
1. docker [installed](https://docs.docker.com/install/)
1. [Rancher Desktop](https://rancherdesktop.io) or [Podman Desktop](https://podman-desktop.io) installed

#### Setup steps

Expand Down
2 changes: 2 additions & 0 deletions trivy-secret.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
disable-rules:
- jwt-token

0 comments on commit 7e99e92

Please sign in to comment.