Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--diff-branch option to allow for scans of changed files only #143

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nickrayjones
Copy link
Member

@nickrayjones nickrayjones commented Dec 18, 2023

My git component has an extremely large code base and it takes hours to
scan all files in the repository. Our builds only perform incremental
changes, building only the changed source files. Because of this it is
only necessary to scan changed source files during the build process.

This enhancement saves hours of downtime on incremental builds only
changing a few source files out of thousands.

There is also a tweak to allow detect-secrets to run on z/OS by
acknowledging code 129 as a file not found code.

init.py added to tests directories to allow testing to run

in baseline_test.py, setup renamed to setup_method per the guidance
https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose

* --diff-branch

* tests

* https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose

* test

* +

* +

* test

* ?

* fix git diff command syntax, tests

* spelling

* test

* --diff-branch

Signed-off-by: Nick Jones <[email protected]>

* tests

Signed-off-by: Nick Jones <[email protected]>

* https://docs.pytest.org/en/stable/deprecations.html#support-for-tests-written-for-nose

Signed-off-by: Nick Jones <[email protected]>

* test

Signed-off-by: Nick Jones <[email protected]>

* +

Signed-off-by: Nick Jones <[email protected]>

* +

Signed-off-by: Nick Jones <[email protected]>

* test

Signed-off-by: Nick Jones <[email protected]>

* ?

Signed-off-by: Nick Jones <[email protected]>

* fix git diff command syntax, tests

Signed-off-by: Nick Jones <[email protected]>

* spelling

Signed-off-by: Nick Jones <[email protected]>

* test

Signed-off-by: Nick Jones <[email protected]>

* formatting corrections

* fix

* fix

* change quote style

* update .secrets.baseline

---------

Signed-off-by: Nick Jones <[email protected]>
Signed-off-by: Nick Jones <[email protected]>
@alexwoodgate
Copy link

Has there been any progress or blocker for this PR? My team is also very interested the option to help reduce the time detect-secrets takes in our builds

@nickrayjones
Copy link
Member Author

nickrayjones commented Mar 26, 2024

Hi Alex, I think I need to have this reviewed, but I lack the ability to assign reveiwers. Maybe @williamsbritt can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants