Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/csi 3848 call home create new object #244

Closed
wants to merge 71 commits into from
Closed

Feature/csi 3848 call home create new object #244

wants to merge 71 commits into from

Conversation

ArbelNathan
Copy link
Contributor

No description provided.

arbelnat added 25 commits February 7, 2022 14:00
add callhome object
35c8c3f
update file with generate
680c65f
labels test
e859d8e
remove labels test
4348120
deployment to StatefulSet
fe7ed59
deployment to StatefulSet
b3e4347
defaults
4388be0
test adding secret
2d8b65d
add management_address env var
6b36db9
naming and consts
c50a75c
CallHome is Optional
73bdb40
update gen
e9c4c19
remove imagePullSecrets
e7be547
test with cronjob
efdcba1
test with cronjob, remove selctor and add batch to role and RestartPo…
d868343 
…licy
Schedule from CR
1cef0d9
job's pod labels
e23dfe3 
SuccessfulJobsHistoryLimit to 1
adding call home ClusterRole
9e0954c
adding namespaces role
4facf75
create ServiceAccount
404bf77
create ClusterRoleBinding
f079767
add pod to clusterrole
58bf2d8
add cronjobs to role.yaml
3d0a533
Merge remote-tracking branch 'origin/develop' into feature/CSI-3848_c…
100e70d 
…all_home_create_new_object
clean
d4410ca
oriyarde
oriyarde previously approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@oriyarde oriyarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM GJ

matancarmeli7
matancarmeli7 previously approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@matancarmeli7 matancarmeli7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ArbelNathan ArbelNathan dismissed stale reviews from matancarmeli7 and oriyarde via a16815e March 1, 2022 14:11
@ArbelNathan ArbelNathan closed this Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oriyarde oriyarde oriyarde left review comments

@matancarmeli7 matancarmeli7 matancarmeli7 left review comments

@roysahar roysahar Awaiting requested review from roysahar

@barakda barakda Awaiting requested review from barakda

@annaparienti annaparienti Awaiting requested review from annaparienti

@tyichye19 tyichye19 Awaiting requested review from tyichye19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArbelNathan @matancarmeli7 @oriyarde