Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC can set min PV size and condition for MAX PV Size limit #1150

Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

badri-pathak
Copy link
Member

@badri-pathak badri-pathak commented May 2, 2024

Pull request checklist


Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature Enhancement
  • Test Automation
  • Code Refactoring (no functional changes, no api changes)
  • Build related changes
  • Community Operator listing
  • Other (please describe):

What is the current behavior?

What is the new behavior?

  • PV size higher than the scale-allowed size(999999999999999Ki) is not allowed.
  • (Optional) Storage class can be configured to set min PV size. If PV requested with lesser value than the SC limit, then minSize of the SC will be used.
    apiVersion: storage.k8s.io/v1 kind: StorageClass metadata: name: ibm-spectrum-scale-csi-fileset namespace: ibm-spectrum-scale-csi-driver provisioner: spectrumscale.csi.ibm.com parameters: volBackendFs: "fs1" pvMinSize: 3Gi reclaimPolicy: Delete

How risky is this change?

  • Small, isolated change
  • Medium, requires regression testing
  • Large, requires functional and regression testing

Signed-off-by: badri-pathak <[email protected]>
@badri-pathak
Copy link
Member Author

Image: quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:pv_minsize_requirement_v3

@badri-pathak
Copy link
Member Author

This issue will be handled in this PR: #800

@deeghuge deeghuge marked this pull request as draft August 19, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants