pvc size shouldn't more than scale allowed size #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: badri-pathak <[email protected]>
|
Image: quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:pvc_max_size_v6 |
badri-pathak
requested review from
Jainbrt,
deeghuge,
saurabhwani5 and
hemalathagajendran
saurabhwani5
reviewed
Oct 3, 2024
There was a problem hiding this comment.
Hi @badri-pathak , can we fix following issues in this PR
#1227 and #1228
Signed-off-by: badri-pathak <[email protected]>
Jainbrt
previously approved these changes
Oct 7, 2024
saurabhwani5
reviewed
Oct 7, 2024
Signed-off-by: badri-pathak <[email protected]>
Signed-off-by: badri-pathak <[email protected]>
|
image with latest changes : |
Signed-off-by: badri-pathak <[email protected]>
Signed-off-by: badri-pathak <[email protected]>
|
Image: quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:pvc_max_size_v10 |
Signed-off-by: badri-pathak <[email protected]>
|
quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:pvc_max_size_v11 |
saurabhwani5
approved these changes
Oct 10, 2024
|
do not merge in 2.13 |
hemalathagajendran
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: badri-pathak [email protected]
Pull request checklist
This will address the issue #800
The max size supported by scale is 999999999999999K . The changes won't allow the user to create/resize more this allowed limit.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
What is the new behavior?
How risky is this change?