Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node add fix #664

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Node add fix #664

merged 1 commit into from
Jun 28, 2022

Conversation

rajan-mis
Copy link
Member

Signed-off-by: Rajan Mishra [email protected]

Signed-off-by: Rajan Mishra <[email protected]>
@rajan-mis rajan-mis requested review from mamuthiah and acch June 28, 2022 14:14
@rajan-mis rajan-mis merged commit e26ef9e into IBM:nextgen Jun 28, 2022
@acch
Copy link
Contributor

acch commented Jul 1, 2022

Why add a separate set_fact task? Can't we simply define the new var (scale_vars_update) within the existing assert task - or is it used anywhere else?

    - name: update | Check if any running node needs to be updated
      vars:
        msg: |-
          ...
        scale_vars_update: ...
      assert:
        that:
          - "{{ 'True' not in scale_vars_update }}"
        msg: "{{ msg.split('\n') }}"

@rajan-mis
Copy link
Member Author

Why add a separate set_fact task? Can't we simply define the new var (scale_vars_update) within the existing assert task - or is it used anywhere else?

    - name: update | Check if any running node needs to be updated
      vars:
        msg: |-
          ...
        scale_vars_update: ...
      assert:
        that:
          - "{{ 'True' not in scale_vars_update }}"
        msg: "{{ msg.split('\n') }}"

@acch Thanks, agree i will change this in the same task.

@rajan-mis
Copy link
Member Author

@acch Created Issue to incorporate this enhancement.
#665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants