Allow transparent usage of s3 interfaces using s3v2 signature_version #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for older S3 interfaces
Fixed function definition
Added try/except behaviour to support S3 interfaces with old signature_version
|
Hi, apologies for the issues with DCO. I'm not sure how to solve this issue. Would closing this pull request, rebasing my branch with --signoff, and opening a new pull request (directly from the branch on my fork) be preferable, or is there someway to correct this within this pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a config variable "signature_version" that is set through trying an s3v4 signature first, then falls back to s3v2 through excepting on a ClientError if s3v4 isn't accepted by the s3 interface.
This is required for transparently allowing users to connect to S3 interfaces that cannot be updated to use the s3v4 signature_version.