Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity query optimized #560

Merged
merged 31 commits into from
Aug 8, 2023
Merged

Sanity query optimized #560

merged 31 commits into from
Aug 8, 2023

Conversation

tanyaveksler
Copy link
Member

No description provided.

Keeping optimized properties separated per rule (instead of the union of all policy rules)
Fixed handling HostEPs in optimized implementation.

Signed-off-by: Tanya <[email protected]>
Keeping optimized properties separated per rule (instead of the union of all policy rules)
Fixed handling HostEPs in optimized implementation.

Signed-off-by: Tanya <[email protected]>
Returning 'passed' code for skipped queries.

Signed-off-by: Tanya <[email protected]>
Keeping optimized properties separated per rule (instead of the union of all policy rules)
Fixed handling HostEPs in optimized implementation.

Signed-off-by: Tanya <[email protected]>
Keeping optimized properties separated per rule (instead of the union of all policy rules)
Fixed handling HostEPs in optimized implementation.

Signed-off-by: Tanya <[email protected]>
…e times for the same rule, for example when a rule appears twice in a config).

Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
Commented out containment fullExplanation result comparison in tests, since optimized solution gives more accurate result that differs from the original expected result, and thus the test fails.

Signed-off-by: Tanya <[email protected]>
Commented out twoWayContainment fullExplanation result comparison in tests, since optimized solution gives more accurate result that differs from the original expected result, and thus the tests fail.

Signed-off-by: Tanya <[email protected]>
Signed-off-by: Tanya <[email protected]>
Commenting out detailed difference result for some tests, since optimized implementation results are sometimes more detailed than the original ones.

Signed-off-by: Tanya <[email protected]>
Adding implemented queries also to run_all_tests.py

Signed-off-by: Tanya <[email protected]>
@tanyaveksler tanyaveksler self-assigned this Jul 16, 2023
@tanyaveksler tanyaveksler requested a review from adisos July 25, 2023 07:47
Signed-off-by: Tanya <[email protected]>
adisos
adisos previously approved these changes Aug 5, 2023
Signed-off-by: Tanya <[email protected]>
Copy link
Member

@adisos adisos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's first complete the intersects PR, as this one contains also that changes from there.

adisos
adisos previously approved these changes Aug 8, 2023
Signed-off-by: Tanya <[email protected]>
@tanyaveksler tanyaveksler merged commit 1190864 into master Aug 8, 2023
16 checks passed
@tanyaveksler tanyaveksler deleted the sanity-query-optimized branch August 8, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants