Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify_output flag #576

Merged
merged 7 commits into from
Aug 2, 2023
Merged

simplify_output flag #576

merged 7 commits into from
Aug 2, 2023

Conversation

haim-kermany
Copy link
Collaborator

added a flag to avoid putting nodes in a namespace square in a dot file.
needed for cases when graphwiz has issues with the created dot file

@haim-kermany
simplify_output
11db439 
Signed-off-by: haim-kermany <[email protected]>
@haim-kermany haim-kermany requested a review from adisos July 26, 2023 14:33
@adisos adisos linked an issue Aug 1, 2023 that may be closed by this pull request
connectivity output graph issue #568
Closed
adisos
adisos reviewed Aug 2, 2023
View reviewed changes
Copy link
Member

@adisos adisos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments.
The graph generated on the example from the issue does look much better.

nca/FWRules/DotGraph.py Show resolved Hide resolved
nca/nca_cli.py Outdated Show resolved Hide resolved
@haim-kermany haim-kermany merged commit 1aa65b6 into master Aug 2, 2023
16 checks passed
@haim-kermany haim-kermany deleted the issue-568-graphwiz-rank-error branch August 2, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisos adisos adisos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

connectivity output graph issue
2 participants
@haim-kermany @adisos