Skip to content
This repository has been archived by the owner on May 31, 2024. It is now read-only.

Migrate favicon to svg #475

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

d4rkm3z
Copy link

@d4rkm3z d4rkm3z commented Oct 17, 2021

Resolve #359

Copy link
Member

@abdonrd abdonrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution! 👏🏻

And excuse me for the so late response!

I have read that .svg is not working for all browsers, so we need to have an .ico fallback.

@@ -17,7 +17,7 @@

<base href="/" />

<link rel="icon" href="images/favicon.ico" />
<link rel="icon" href="images/logo.svg" type="image/svg+xml" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<link rel="icon" href="images/logo.svg" type="image/svg+xml" />
<link rel="icon" href="/favicon.ico" sizes="any">
<link rel="icon" href="/favicon.svg" type="image/svg+xml">

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate favicon to svg
2 participants