Signed-off-by: Bharath Sakthivel <[email protected]> #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ran detect-secrets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ran detect-secrets
As part of “IBM Cloud 3Q2022: FS-IA readiness”, all the IBM/KMS repositories must enable “Detect Secrets” tool detect secrets, also scan and audit the secrets in their repositories before 8/21/2022.
In this PR I’ve enabled “detect-secrets” and also scanned this repository. The results are in file
.secrets.baseline.I request that the team audit the potential secrets discovered in this scan.
Action to take by any contributor of this repo before merging
The setup should be quick. The audit itself will take only a few minutes on each repo or maybe 10 minutes on a very large repo.
Installation of secret detect is quick, but there is also a docker method available if you have docker desktop that takes no setup (Using docker to run detect secrets).
For further info on detect-secrets please visit: https://w3.ibm.com/w3publisher/detect-secrets/developer-tool
FYI : Henry Grantham, Dinesh Venkatraman
Thanks