fix(sasl): add nilguard around token to prevent panic #3076

hoo47 · 2025-01-10T06:34:15Z

Currently, there is no Token nil inspection.
as-is: if token.Extensions != nil && len(token.Extensions) > 0 {
to-be: if token != nil && token.Extensions != nil && len(token.Extensions) > 0 {

broker.go

puellanivis · 2025-01-13T19:22:20Z

👍

Signed-off-by: hoo47 <[email protected]> Signed-off-by: hoo47 <[email protected]>

dnwe · 2025-01-14T09:08:41Z

Thanks! LGTM

puellanivis reviewed Jan 10, 2025

View reviewed changes

broker.go Outdated Show resolved Hide resolved

puellanivis reviewed Jan 10, 2025

View reviewed changes

broker.go Outdated Show resolved Hide resolved

hoo47 force-pushed the fix/token branch from 14def87 to 485ae81 Compare January 13, 2025 17:12

hoo47 force-pushed the fix/token branch from 485ae81 to 9c2a971 Compare January 14, 2025 04:57

hoo47 added 2 commits January 14, 2025 13:58

chore: avoid npe when token is nil

d40e9fc

Signed-off-by: hoo47 <[email protected]> Signed-off-by: hoo47 <[email protected]>

refactor: apply comments

1788993

Signed-off-by: hoo47 <[email protected]> Signed-off-by: hoo47 <[email protected]>

hoo47 force-pushed the fix/token branch from 9c2a971 to 1788993 Compare January 14, 2025 04:58

hoo47 requested a review from puellanivis January 14, 2025 04:59

dnwe changed the title ~~chore: avoid NPE when token is nil~~ fix(sasl): add nilguard around token to prevent panic Jan 14, 2025

dnwe added the fix label Jan 14, 2025

dnwe approved these changes Jan 14, 2025

View reviewed changes

dnwe merged commit 4ffab23 into IBM:main Jan 14, 2025
1 check passed

Provide feedback