Skip to content
This repository has been archived by the owner on Jul 20, 2023. It is now read-only.

Update to trino 359 #77

Merged
merged 1 commit into from
Jul 25, 2021
Merged

Update to trino 359 #77

merged 1 commit into from
Jul 25, 2021

Conversation

meneal
Copy link
Contributor

@meneal meneal commented Jul 23, 2021

@meneal meneal force-pushed the upgrade-to-359 branch 4 times, most recently from 10b2633 to 47e71e1 Compare July 23, 2021 21:16
@meneal
Copy link
Contributor Author

meneal commented Jul 23, 2021

@shawnzhu please review.

@meneal
Copy link
Contributor Author

meneal commented Jul 23, 2021

Fixes #78

@meneal
Copy link
Contributor Author

meneal commented Jul 23, 2021

Test Configuration

Run: mvn clean install

Add files to conf:

tree conf
conf
└── trino
    ├── catalog
    │   └── badis.properties
    ├── config.properties
    ├── jvm.config
    └── node.properties

2 directories, 4 files
cat conf/trino/config.properties
coordinator=true
node-scheduler.include-coordinator=true
http-server.http.port=8080
discovery-server.enabled=true
discovery.uri=http://trino-coordinator:8080
cat conf/trino/jvm.config
# from https://github.com/prestosql/presto/blob/master/docker/default/etc/jvm.config
-server
-Xmx1G
-XX:-UseBiasedLocking
-XX:+UseG1GC
-XX:G1HeapRegionSize=32M
-XX:+ExplicitGCInvokesConcurrent
-XX:+HeapDumpOnOutOfMemoryError
-XX:+UseGCOverheadLimit
-XX:+ExitOnOutOfMemoryError
-XX:ReservedCodeCacheSize=256M
-Djdk.attach.allowAttachSelf=true
-Djdk.nio.maxCachedBufferSize=2000000
cat conf/trino/node.properties
node.environment=development
node.data-dir=/data/trino
plugin.dir=/usr/lib/trino/plugin
cat docker-compose.yaml
# docker-compose.yml
version: "3.7"

services:
  trino-coordinator:
    image: trinodb/trino:359
    container_name: trino-coordinator
    volumes:
    - source: ./target/trino-db2-359
      target: /usr/lib/trino/plugin/db2
      type: bind
    - source: ./conf/trino
      target: /etc/trino
      type: bind
    ports:
      - "8080:8080"

The below is redacted for safety

cat conf/trino/catalog/badis.properties
connector.name=db2
connection-url=jdbc:db2://ip:port/database
connection-user=myuser
connection-password=mypassword

Setup as above and run:

  • docker compose up -d
  • trino
    and then follow up by running
  • show catalogs
  • use <catalog>.<schema>
  • select * from <some table>

Copy link
Contributor

@shawnzhu shawnzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shawnzhu
Copy link
Contributor

@apreethi13 FYI

@meneal
Copy link
Contributor Author

meneal commented Jul 24, 2021

@shawnzhu I lack the permissions to merge, and likely to cut a release. Please merge and cut a release for 359 when you have a chance.

@shawnzhu shawnzhu merged commit 2211ac7 into IBM:main Jul 25, 2021
@shawnzhu
Copy link
Contributor

Done

@shawnzhu shawnzhu mentioned this pull request Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants