This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
Upgrade to 364 #80
Merged
Upgrade to 364 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apreethi13
reviewed
Nov 15, 2021
| volumes: | ||
| - source: ./target/presto-db2-347 | ||
| target: /usr/lib/presto/plugin/db2 | ||
| - source: ./target/trino-db2-<trino_verson_from_pom> |
There was a problem hiding this comment.
since it still points to presto-db2 in Dockerfile
Line 3 in 112b4cc
Should the source and target be presto-db2 ?
There was a problem hiding this comment.
Notice that nothing really seems to even use the Dockerfile. The image that is being used in the suggested docker-compose.yaml is based on the upstream image on dockerhub. I think the Dockerfile is kind of an artifact at this point.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81