For issue 1575: Eliminating Manual Class Registration in Unitxt, replaced by Import Paths #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafnapension
force-pushed
the
json
branch
2 times, most recently
from
d9425b2 to
3c9f7fa
Compare
|
For: #1575 |
dafnapension
force-pushed
the
json
branch
10 times, most recently
from
54efa18 to
137df10
Compare
dafnapension
changed the title
dafnapension
changed the title
dafnapension
changed the title
…ake, and remove _class_register altogether Signed-off-by: dafnapension <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__type__in catalog is expressed as qualified class name, therefrom classes are instantiated through python's import. Artifact._class_register is removed altogether