Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin scheduler #76

Closed
wants to merge 1 commit into from
Closed

Conversation

yannicks1
Copy link
Contributor

@yannicks1 yannicks1 commented Feb 4, 2025

This PR moves the (spyre specific) scheduler class into the plugin repo vllm-spyre.
it goes along with this ->PR<- in the vllm-spyre repository

Changes:

  • vllm/config.py: importing SchedulerConfig from vllm-spyre plugin instead of using the upstream SchedulerConfig
  • vllm/core/scheduler.py: importing Scheduler from vllm-spyre plugin instead of using the upstream Scheduler
  • vllm/envs.py: removing spyre specific variables (moved to vllm-spyre)

Note: I squashed the four commits of this iterative process to arrive at this solution into one commit for better readability.

Copy link

github-actions bot commented Feb 4, 2025

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@yannicks1 yannicks1 force-pushed the ysc-plugin-scheduler branch from dbdf4bf to a65145f Compare February 6, 2025 09:23
@yannicks1 yannicks1 marked this pull request as ready for review February 6, 2025 09:44
Copy link
Member

@sducouedic sducouedic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sducouedic
Copy link
Member

sducouedic commented Feb 6, 2025

We will have issue with the git workflow which cannot import vllm_spyre...
We will probably need to update the workflows before merging with main or the 17.01.2025 branch.

@tdoublep
Copy link
Member

tdoublep commented Feb 6, 2025

I think we should first implement the mechanism to make the scheduler pluggable before moving the scheduler code into vllm-spyre. Otherwise, we end up creating a dependency on vllm-spyre within vllm itself, which is not what we want.

We can implement the scheduler pluggable stuff on this fork first, verify that it works, and then try to get the changes accepted upstream.

@yannicks1
Copy link
Contributor Author

this PR is replaced by an alternative implementation see this PR

@yannicks1 yannicks1 closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants