Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
tombrunet authored Jan 9, 2024
1 parent 91d44ec commit 669969f
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ <h3 id="ruleMessage"></h3>

### What to do

* If the control is a [label](https://html.spec.whatwg.org/multipage/forms.html#category-label) element, add a `for` attribute to a visible label with the `id` of this control (e.g., `<label for="controlID">`)
* **Or**, if the control is a labe element, put the control inside a visible `<label>` element
* If the control is a [labelable](https://html.spec.whatwg.org/multipage/forms.html#category-label) element, add a `for` attribute to a visible label with the `id` of this control (e.g., `<label for="controlID">`)
* **Or**, if the control is a labelable element, put the control inside a visible `<label>` element
* **Or**, add an `aria-labelledby` attribute to the control. It must point to visible text on the page that is meaningful as a label
* **Or**, if the design cannot have a visible label, provide a label using the `aria-label` attribute (e.g., `aria-label="Activities"`)
* **Or**, if the design cannot have a visible label, use the `title` attribute to provide a label
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"aria": "/document[1]/main[1]/img[1]"
},
"reasonId": "fail_no_alt",
"message": "The image has neither an 'alt' attribute, an ARIA label, or title",
"message": "The image has neither an 'alt' attribute, an ARIA label, nor a title",
"messageArgs": [],
"apiArgs": [],
"category": "Accessibility"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"aria": "/document[1]/main[1]/img[1]"
},
"reasonId": "fail_no_alt",
"message": "The image has neither an 'alt' attribute, an ARIA label, or title",
"message": "The image has neither an 'alt' attribute, an ARIA label, nor a title",
"messageArgs": [],
"apiArgs": [],
"category": "Accessibility"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"aria": "/document[1]/main[1]/img[1]"
},
"reasonId": "fail_no_alt",
"message": "The image has neither an 'alt' attribute, an ARIA label, or title",
"message": "The image has neither an 'alt' attribute, an ARIA label, nor a title",
"messageArgs": [],
"apiArgs": [],
"category": "Accessibility"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"aria": "/document[1]/main[1]/img[2]"
},
"reasonId": "fail_no_alt",
"message": "The image has neither an 'alt' attribute, an ARIA label, or title",
"message": "The image has neither an 'alt' attribute, an ARIA label, nor a title",
"messageArgs": [],
"apiArgs": [],
"category": "Accessibility"
Expand Down

0 comments on commit 669969f

Please sign in to comment.