Skip to content

Commit

Permalink
update messages #1674
Browse files Browse the repository at this point in the history
  • Loading branch information
@shunguoy
shunguoy committed Nov 1, 2023
1 parent 7b22e46 commit 98503e2
Show file tree
Hide file tree
Showing 15 changed files with 306 additions and 150 deletions.
12 changes: 6 additions & 6 deletions accessibility-checker-engine/src/v4/rules/target_spacing_sufficient.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@
},
messages: {
"en-US": {
"group": "The target is sufficiently spaced from other targets",
"pass_spacing": "The target's spacing from other targets is more than minimum",
"group": "The target must be sufficiently sized or spaced from other targets",
"pass_spacing": "The target's spacing from other targets is sufficient",
"pass_sized": "The target’s size is more than 24 CSS pixels",
"pass_inline": "The target is in a sentence or its size is otherwise constrained by the line-height of non-target text",
"pass_default": "The size of the target is determined by the user agent and is not modified by the author",
"violation_spacing": "The center of the target '{0}' is less than 12 CSS pixels from the bounding box (edge) of an adjacent target '{1}'",
"recommendation_inline": "Confirm the inline target '{0}' is sufficiently spaced from aother inline target '{1}'",
"potential_overlap": "Ensure the overlapped element '{0}' meets a minimum target size or has sufficient spacing from the overlapping element '{1}'"
"pass_default": "The target's size is determined by the user agent and is not modified by the author",
"violation_spacing": "Undersized target \"{0}\" does not have sufficient spacing of 12 CSS pixels from another target \"{1}\"",
"recommendation_inline": "Confirm the inline target \"{0}\" is sufficiently spaced from aother inline target \"{1}\"",
"potential_overlap": "Ensure the overlapped target \"{0}\" meets a minimum target size or has sufficient spacing from the overlapping target \"{1}\""
}
},
rulesets: [{
Expand Down
2 changes: 1 addition & 1 deletion accessibility-checker-engine/src/v4/sc-urls.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,7 @@
"num": "2.5.8",
"url": "https://w3c.github.io/wcag/guidelines/22/#target-size-minimum",
"scId": "WCAG2:minimum-target-size",
"scAltId": [],
"scAltId": ["minimum-target-size"],
"test": "WCAG2:WCAG2:minimum-target-size",
"howToMeetUrl": "https://w3c.github.io/wcag/understanding/target-size-minimum.html",
"understandingUrl": "https://w3c.github.io/wcag/understanding/target-size-minimum.html",
Expand Down
10 changes: 5 additions & 5 deletions .../checker/accessibility/rules/target_spacing_sufficient_ruleunit/block_element_inline.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ <h2>display: inline</h2>
"message": "The target is in a sentence or its size is otherwise constrained by the line-height of non-target text",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -113,7 +113,7 @@ <h2>display: inline</h2>
"message": "The target’s size is more than 24 CSS pixels",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -129,7 +129,7 @@ <h2>display: inline</h2>
"message": "The target’s size is more than 24 CSS pixels",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -142,10 +142,10 @@ <h2>display: inline</h2>
"aria": "/document[1]/button[3]"
},
"reasonId": "pass_default",
"message": "The size of the target is determined by the user agent and is not modified by the author",
"message": "The target's size is determined by the user agent and is not modified by the author",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
}
]
}
Expand Down
2 changes: 1 addition & 1 deletion ...accessibility/rules/target_spacing_sufficient_ruleunit/block_overlaid_hidden_default.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
"message": "The target’s size is more than 24 CSS pixels",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
}
]
}
Expand Down
2 changes: 1 addition & 1 deletion .../accessibility/rules/target_spacing_sufficient_ruleunit/block_overlaid_hidden_zindex.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"message": "The target’s size is more than 24 CSS pixels",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
}
]
}
Expand Down
6 changes: 3 additions & 3 deletions ...accessibility/rules/target_spacing_sufficient_ruleunit/block_overlaid_visible_zindex.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"message": "The target’s size is more than 24 CSS pixels",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -88,13 +88,13 @@
"aria": "/document[1]"
},
"reasonId": "potential_overlap",
"message": "Ensure the overlapped element 'div' meets a minimum target size or has sufficient spacing from the overlapping element 'div'",
"message": "Ensure the overlapped target \"div\" meets a minimum target size or has sufficient spacing from the overlapping target \"div\"",
"messageArgs": [
"div",
"div"
],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
}
]
}
Expand Down
18 changes: 9 additions & 9 deletions ...st/v2/checker/accessibility/rules/target_spacing_sufficient_ruleunit/button_examples.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"message": "The target’s size is more than 24 CSS pixels",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -65,10 +65,10 @@
"aria": "/document[1]/button[2]"
},
"reasonId": "pass_default",
"message": "The size of the target is determined by the user agent and is not modified by the author",
"message": "The target's size is determined by the user agent and is not modified by the author",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -81,10 +81,10 @@
"aria": "/document[1]/button[3]"
},
"reasonId": "pass_spacing",
"message": "The target's spacing from other targets is more than minimum",
"message": "The target's spacing from other targets is sufficient",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -97,10 +97,10 @@
"aria": "/document[1]/button[4]"
},
"reasonId": "pass_default",
"message": "The size of the target is determined by the user agent and is not modified by the author",
"message": "The target's size is determined by the user agent and is not modified by the author",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -113,13 +113,13 @@
"aria": "/document[1]/button[5]"
},
"reasonId": "potential_overlap",
"message": "Ensure the overlapped element 'button' meets a minimum target size or has sufficient spacing from the overlapping element 'button'",
"message": "Ensure the overlapped target \"button\" meets a minimum target size or has sufficient spacing from the overlapping target \"button\"",
"messageArgs": [
"button",
"button"
],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
}
]
}
Expand Down
52 changes: 26 additions & 26 deletions ...est/v2/checker/accessibility/rules/target_spacing_sufficient_ruleunit/element_inline.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ <h2 style="margin-top:30px;">display: mixed</h2>
"message": "The target is in a sentence or its size is otherwise constrained by the line-height of non-target text",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -125,7 +125,7 @@ <h2 style="margin-top:30px;">display: mixed</h2>
"message": "The target is in a sentence or its size is otherwise constrained by the line-height of non-target text",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -138,10 +138,10 @@ <h2 style="margin-top:30px;">display: mixed</h2>
"aria": "/document[1]/button[1]"
},
"reasonId": "pass_default",
"message": "The size of the target is determined by the user agent and is not modified by the author",
"message": "The target's size is determined by the user agent and is not modified by the author",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -157,7 +157,7 @@ <h2 style="margin-top:30px;">display: mixed</h2>
"message": "The target is in a sentence or its size is otherwise constrained by the line-height of non-target text",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -170,10 +170,10 @@ <h2 style="margin-top:30px;">display: mixed</h2>
"aria": "/document[1]/textbox[1]"
},
"reasonId": "pass_default",
"message": "The size of the target is determined by the user agent and is not modified by the author",
"message": "The target's size is determined by the user agent and is not modified by the author",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -189,7 +189,7 @@ <h2 style="margin-top:30px;">display: mixed</h2>
"message": "The target’s size is more than 24 CSS pixels",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -205,7 +205,7 @@ <h2 style="margin-top:30px;">display: mixed</h2>
"message": "The target is in a sentence or its size is otherwise constrained by the line-height of non-target text",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -221,7 +221,7 @@ <h2 style="margin-top:30px;">display: mixed</h2>
"message": "The target is in a sentence or its size is otherwise constrained by the line-height of non-target text",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -234,13 +234,13 @@ <h2 style="margin-top:30px;">display: mixed</h2>
"aria": "/document[1]/img[2]"
},
"reasonId": "recommendation_inline",
"message": "Confirm the inline target 'img' is sufficiently spaced from aother inline target 'a'",
"message": "Confirm the inline target \"img\" is sufficiently spaced from aother inline target \"a\"",
"messageArgs": [
"img",
"a"
],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -256,7 +256,7 @@ <h2 style="margin-top:30px;">display: mixed</h2>
"message": "The target is in a sentence or its size is otherwise constrained by the line-height of non-target text",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -269,10 +269,10 @@ <h2 style="margin-top:30px;">display: mixed</h2>
"aria": "/document[1]/button[2]"
},
"reasonId": "pass_default",
"message": "The size of the target is determined by the user agent and is not modified by the author",
"message": "The target's size is determined by the user agent and is not modified by the author",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -285,10 +285,10 @@ <h2 style="margin-top:30px;">display: mixed</h2>
"aria": "/document[1]/button[3]"
},
"reasonId": "pass_default",
"message": "The size of the target is determined by the user agent and is not modified by the author",
"message": "The target's size is determined by the user agent and is not modified by the author",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -301,10 +301,10 @@ <h2 style="margin-top:30px;">display: mixed</h2>
"aria": "/document[1]/button[4]"
},
"reasonId": "pass_default",
"message": "The size of the target is determined by the user agent and is not modified by the author",
"message": "The target's size is determined by the user agent and is not modified by the author",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -320,7 +320,7 @@ <h2 style="margin-top:30px;">display: mixed</h2>
"message": "The target is in a sentence or its size is otherwise constrained by the line-height of non-target text",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -333,10 +333,10 @@ <h2 style="margin-top:30px;">display: mixed</h2>
"aria": "/document[1]/button[5]"
},
"reasonId": "pass_default",
"message": "The size of the target is determined by the user agent and is not modified by the author",
"message": "The target's size is determined by the user agent and is not modified by the author",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -349,10 +349,10 @@ <h2 style="margin-top:30px;">display: mixed</h2>
"aria": "/document[1]/button[6]"
},
"reasonId": "pass_default",
"message": "The size of the target is determined by the user agent and is not modified by the author",
"message": "The target's size is determined by the user agent and is not modified by the author",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
},
{
"ruleId": "target_spacing_sufficient",
Expand All @@ -365,10 +365,10 @@ <h2 style="margin-top:30px;">display: mixed</h2>
"aria": "/document[1]/button[7]"
},
"reasonId": "pass_default",
"message": "The size of the target is determined by the user agent and is not modified by the author",
"message": "The target's size is determined by the user agent and is not modified by the author",
"messageArgs": [],
"apiArgs": [],
"category": "Other"
"category": "Accessibility"
}
]
}
Expand Down
Loading

0 comments on commit 98503e2

Please sign in to comment.