Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WCAG 2.2 rules to Keyboard Check Mode list of rules to be trigger #1726

Closed
1 task done
philljenkins opened this issue Oct 23, 2023 · 6 comments · Fixed by #1733
Closed
1 task done

Add WCAG 2.2 rules to Keyboard Check Mode list of rules to be trigger #1726

philljenkins opened this issue Oct 23, 2023 · 6 comments · Fixed by #1733
Assignees
Labels
documentation Improvements or additions to documentation extension-checker Issues related to the browser extensions priority-1 (high) Ready for QA T54 Triage release 5.4 WCAG 2.2 Issues/Rules related to WCAG 2.2

Comments

@philljenkins
Copy link
Contributor

philljenkins commented Oct 23, 2023

When running KCM, additional new WCAG 2.2 rules related to tab stops should also be fired, such as WCAG 2.2 new rules:

Related rules

  • similar to the existing rule: element_tabbable_visible, (not off-screen) which is already in KCM list
  • WCAG 2.2 new rule: target_spacing_sufficient is not included because it is related only to touch and mouse target size. Not keyboard-related.
  • WCAG 2.2 new rule: element_draggable_alternative is not included because it has to do with providing a single pointer (mouse click) alternative to dragging. Not keyboard-related.

List of rules for KCM

The KCM rules are in: .../accessibility-checker-extension/src/ts/util/UtilKCM.tsx

  • add rule to KCM list
@philljenkins philljenkins added the WCAG 2.2 Issues/Rules related to WCAG 2.2 label Oct 23, 2023
@philljenkins
Copy link
Contributor Author

philljenkins commented Oct 23, 2023

Also, fix the User Guide in chrome-extension://lkcagbfjnkomcinoddgooolagloogehp/usingAC.html#keyboard_checker_mode, which incorrectly refers to "the triangle icons"

Manual keyboard testing
Automated tools can’t find all keyboard access issues. Using the visualization, test for basic keyboard navigation:

  1. Make sure every interactive element is a tab stop*
  2. No tab stops on non-interactive or non-visible elements**
  3. Tab order matches the visual flow of the page
  4. Inspect elements with found issues (select the triangle icons)

Note that the following is already in the Quick Guide content AND in the preceding section in the User's Guide:
image

However, it might be better to instead link to the Verify - Manual section in the Toolkit so that it is maintained in only one place. Or, duplicate the content by replacing/harmonizing the "Manual keyboard testing" section in the User Guide with content from the following links in the Toolkit:

@philljenkins philljenkins added extension-checker Issues related to the browser extensions documentation Improvements or additions to documentation priority-1 (high) labels Oct 23, 2023
@drjoho drjoho self-assigned this Oct 30, 2023
@shunguoy shunguoy added the T54 Triage release 5.4 label Oct 30, 2023
@philljenkins
Copy link
Contributor Author

@drjoho The test cases that will trigger this new rule are in a ruleunit folder.
Open each .html file (test case) and run the Checker & KCM to determine if the new rule is added correctly.

https://github.com/IBMa/equal-access/tree/master/accessibility-checker-engine/test/v2/checker/accessibility/rules/element_tabbable_unobscured_ruleunit

@drjoho
Copy link
Contributor

drjoho commented Nov 2, 2023

Done. Phil will review and then will be ready for test.

@philljenkins
Copy link
Contributor Author

also removed reference to old triangle icons

@ErickRenteria
Copy link
Contributor

ErickRenteria commented Nov 7, 2023

We're showing a violation in the KCM but should be a needs review. Also the KCM format needs improvement.
tested with accessibility-checker-engine/test/v2/checker/accessibility/rules/element_tabbable_unobscured_ruleunit/element_overlaid_hidden_zindex.html

Please review attachment.
Screenshot 2023-11-07 at 1 36 22 PM
Screenshot 2023-11-07 at 1 37 21 PM
Screenshot 2023-11-06 at 10 26 29 PM

Not ready for QA @drjoho please review

@ErickRenteria
Copy link
Contributor

Validated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation extension-checker Issues related to the browser extensions priority-1 (high) Ready for QA T54 Triage release 5.4 WCAG 2.2 Issues/Rules related to WCAG 2.2
Projects
None yet
4 participants