Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(Keyboard Checker Mode): Added new WCAG 2.2: 2.4.11 Focus not obscured (Minimum) rule element_tabbable_unobscured #1733

Merged
merged 3 commits into from
Nov 7, 2023
Merged

feature(Keyboard Checker Mode): Added new WCAG 2.2: 2.4.11 Focus not obscured (Minimum) rule element_tabbable_unobscured #1733

merged 3 commits into from
Nov 7, 2023

Conversation

drjoho
Copy link
Contributor

@drjoho drjoho commented Nov 2, 2023 •
edited by philljenkins
Loading

  • New Rule(s): add rule to the list of the Keyboard Rules

This PR is related to the following issue(s):

#1726

Additional information can be found here:

Testing reference:

[https://github.com/IBMa/equal-access/tree/master/accessibility-checker-engine/test/v2/checker/accessibility/rules/element_tabbable_unobscured_ruleunit]

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@drjoho drjoho changed the title added 2.2 rule element_tabbable_unobscured feature(element_tabbable_unobscured): WCAG 2.2: 2.4.11 Focus not obscured (Minimum) Nov 2, 2023
@philljenkins philljenkins changed the title feature(element_tabbable_unobscured): WCAG 2.2: 2.4.11 Focus not obscured (Minimum) feature(element_tabbable_unobscured): WCAG 2.2: 2.4.11 Focus not obscured (Minimum) added to Keyboard Checker Mode Nov 2, 2023
@drjoho drjoho requested a review from philljenkins November 2, 2023 21:23
philljenkins
philljenkins previously approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested with Josiah

@philljenkins philljenkins linked an issue Nov 2, 2023 that may be closed by this pull request
Add WCAG 2.2 rules to Keyboard Check Mode list of rules to be trigger #1726
Closed
1 task
philljenkins
philljenkins approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caught the remaining incorrect reference to the old triangle icons

@ErickRenteria
Copy link
Contributor

No ready for production

@ErickRenteria ErickRenteria merged commit bc32ebb into master Nov 7, 2023
15 checks passed
@philljenkins philljenkins changed the title feature(element_tabbable_unobscured): WCAG 2.2: 2.4.11 Focus not obscured (Minimum) added to Keyboard Checker Mode feature(element_tabbable_unobscured): WCAG 2.2: 2.4.11 Focus not obscured (Minimum) added to Keyboard Checker Mode Nov 8, 2023
@philljenkins philljenkins changed the title feature(element_tabbable_unobscured): WCAG 2.2: 2.4.11 Focus not obscured (Minimum) added to Keyboard Checker Mode feature(Keyboard Checker Mode): Added new WCAG 2.2: 2.4.11 Focus not obscured (Minimum) rule element_tabbable_unobscured Nov 8, 2023
@tombrunet tombrunet deleted the joho-2.2KBrule-1726 branch April 11, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philljenkins philljenkins philljenkins approved these changes

Assignees

@ErickRenteria ErickRenteria

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add WCAG 2.2 rules to Keyboard Check Mode list of rules to be trigger
3 participants
@drjoho @ErickRenteria @philljenkins