Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Formatting issue and typo in help for element_mouseevent_keyboard #941

Closed
7 tasks done
aliunwala opened this issue Jun 7, 2022 · 13 comments · Fixed by #1719
Closed
7 tasks done

[BUG] Formatting issue and typo in help for element_mouseevent_keyboard #941

aliunwala opened this issue Jun 7, 2022 · 13 comments · Fixed by #1719
Assignees
Labels
Bug Something isn't working development engine Issues in the accessibility-checker-engine component priority-3 (low) Ready for QA SME Discuss with subject matter experts T54 Triage release 5.4

Comments

@aliunwala
Copy link
Contributor

aliunwala commented Jun 7, 2022

What tool(s) are you using?

  • accessibility-checker-engine
  • accessibility-checker

Detailed description

Platform: Mac Big Sur, Chrome

Help contains a table that is not rendered with the correct font or clear table structure.
New 2023-10-24: that text color in the "table" remains black and therefore fails in one of the dark modes
There is an extra ')' in the 'About this requirement' section.

  • ws the old E2E issue #3153

Steps to reproduce the issue

  1. Open the test page: equal-access/accessibility-checker-engine/test/v2/checker/accessibility/rules/Rpt_Aria_EventHandlerMissingRole_Native_Host_Sematics_ruleunit/eventHandlerMissingRole2.html
  2. Run the checker on this page
  3. Find the issue 'Confirm the
    element with mouse event handler(s) 'onclick' has a corresponding keyboard handler(s)'
  4. Open the help for this issue - it contains two three (3)problems:
  • a table that is not formatted, the text color doesn;t honor dark mode, and
  • a stray ')' in the 'About this requirement' section

Additional information

Screen Shot 2021-05-27 at 8.05.18 PM.png

——————
As of June 1

  • general rule description (SME & Dev)
  • testcases written (Dev)
  • rule developed (Dev)
  • message written (SME)
  • help written (SME)

image

@aliunwala aliunwala added Bug Something isn't working engine Issues in the accessibility-checker-engine component SME Discuss with subject matter experts priority-3 (low) development and removed SME Discuss with subject matter experts development labels Jun 7, 2022
@aliunwala
Copy link
Contributor Author

aliunwala commented Jun 7, 2022

Triage:
Making this dev since we have a table formatting error.
However, this is simple MDX

@philljenkins philljenkins self-assigned this Jun 29, 2023
@MHoov MHoov added the SME Discuss with subject matter experts label Jun 30, 2023
@marcjohlic
Copy link
Member

@philljenkins do you have an update on this one?

@philljenkins
Copy link
Contributor

philljenkins commented Oct 24, 2023

The rule was re-named to
element_mouseevent_keyboard: All interactive content with mouse event handlers must have equivalent keyboard access

  • and the "table" still has a formatting problem displaying the data table, and has a newly found issue displaying text in one dark mode:
    image

@philljenkins
Copy link
Contributor

philljenkins commented Oct 25, 2023

The "extra parentheses" is still there in the first bullet, but that is a very simple fix

@philljenkins
Copy link
Contributor

philljenkins commented Oct 25, 2023

However, when the Help is displayed inside the Checker UI, the black text color is transformed correctly to white, however, the table formatting (no CSS?) is still odd.:
image

@philljenkins
Copy link
Contributor

philljenkins commented Oct 25, 2023

Some changes, such as removing the ")" have been made in dev-1674 branch / PR #1719
accessibility-checker-engine/help-v4/en-US/element_mouseevent_keyboard.html

https://github.com/IBMa/equal-access/pull/1719/files#diff-e4d9dfd0b8cee30762cc00be33288cea1cbabf4b78123e3775df5815cf742131

@philljenkins philljenkins changed the title [BUG] Formatting issue and typo in help for RPT_Elem_EventMouseAndKey #3153 [BUG] Formatting issue and typo in help for element_mouseevent_keyboard Oct 26, 2023
@philljenkins
Copy link
Contributor

assigning to Tom to fix the CSS both in Checker and Rule sets web page.

@tombrunet
Copy link
Member

@philljenkins I put the formatting issues into a separate PR since I needed to touch all of the help files to make sure they had the doctype declaration. See #1730. Image with mouse hover of the second row.

image

@tombrunet
Copy link
Member

Also, the only help file I could find with a table is element_mouseevent_keyboard.html.

@philljenkins
Copy link
Contributor

I reviewed & approved the PR #1730

@philljenkins
Copy link
Contributor

philljenkins commented Oct 30, 2023

@ErickRenteria the PR #1730 can be tested by running the ruleunit testcase and displaying the Help to see the table formatted in the Help page
... equal-access/accessibility-checker-engine/test/v2/checker/accessibility/rules/element_mouseevent_keyboard_ruleunit/Events-invalidNoMouseRequired.svg

Also note that building all PR's now generates a Rule listing artifact in the Actions (see screenshot) that lists the rules, showing the new WCAG 2.2 (A, AA) option, rule & mapping fixes, messages updated, and any new WCAG 2.2 rules, such as

2.4.11 Focus Not Obscured (Minimum) [AA]
When an element receives focus, it is not entirely covered by other content.
element_tabbable_unobscured: When an element receives focus, it is not entirely covered by other content

image

image

@philljenkins
Copy link
Contributor

philljenkins commented Oct 30, 2023

The earlier fixes are in PR #1719
where this typo is fixed
image

@philljenkins
Copy link
Contributor

philljenkins commented Oct 31, 2023

I update the README-RULES.md in
https://github.com/IBMa/equal-access/blob/dev-1674/accessibility-checker-engine/README-RULES.md
with the new sub-section in PR #1719

Rules sets and Mappings

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working development engine Issues in the accessibility-checker-engine component priority-3 (low) Ready for QA SME Discuss with subject matter experts T54 Triage release 5.4
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants