Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(help): Fix style issues with tables in help #1730

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Conversation

tombrunet
Copy link
Member

@tombrunet tombrunet commented Oct 30, 2023

This PR is related to the following issue(s):

Additional information can be found here:

Testing reference:

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@tombrunet
Copy link
Member Author

Image with mouse over of the second row:
image

The only help file I could find with a table is element_mouseevent_keyboard.html.

@philljenkins philljenkins self-assigned this Oct 30, 2023
Copy link
Contributor

@philljenkins philljenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the CSS changes, additions for table, and the new DocType in all the Help .html files

@philljenkins
Copy link
Contributor

@ErickRenteria this PR can be tested by running the ruleunit testcase and displaying the Help to see the table formatted in the Help page
... equal-access/accessibility-checker-engine/test/v2/checker/accessibility/rules/element_mouseevent_keyboard_ruleunit/Events-invalidNoMouseRequired.svg

Also note that building all PR's now generates a Rule listing artifact in the Actions (see screenshot) that lists the rules, showing the new WCAG 2.2 (A, AA) option and the new WCAG 2.2 rules, such as

2.4.11 Focus Not Obscured (Minimum) [AA]
When an element receives focus, it is not entirely covered by other content.
element_tabbable_unobscured: When an element receives focus, it is not entirely covered by other content

image

image

@ErickRenteria
Copy link
Contributor

Under review

@ErickRenteria ErickRenteria merged commit 0cf827f into master Nov 2, 2023
15 checks passed
@tombrunet tombrunet deleted the html5-doctypes branch April 11, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants