Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newrule(target_spacing_sufficient): WCAG 2.2: 2.5.8 Target size (minimum) #1719

Merged
merged 57 commits into from
Nov 9, 2023
Merged
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
e7bffa6
Merge pull request #1714 from IBMa/dev-1676
shunguoy Oct 12, 2023
8272bec
create initial rule #1674
shunguoy Oct 12, 2023
6fd5aa6
initial rule #1674
shunguoy Oct 13, 2023
0e811d3
initial rule #1674
shunguoy Oct 13, 2023
41d127d
initial rule #1674
shunguoy Oct 13, 2023
ee16f58
add utilities for target #1674
shunguoy Oct 16, 2023
5d1db0e
Merge branch 'master' into dev-1674
shunguoy Oct 17, 2023
dcb35ab
add more test cases #1674
shunguoy Oct 17, 2023
1157e8e
update rule and test cases #1674
shunguoy Oct 19, 2023
e9b4fe8
update test cases #1674
shunguoy Oct 19, 2023
a5e35b8
update the rule #1674
shunguoy Oct 23, 2023
7af7b56
New WCAG 2.2 help
philljenkins Oct 23, 2023
7a75e2f
Merge branch 'master' into dev-1674
shunguoy Oct 24, 2023
bd52e01
rule update #1674
shunguoy Oct 25, 2023
2b97681
remove trailing ")"
philljenkins Oct 25, 2023
d910f04
simplify table
philljenkins Oct 25, 2023
94d077d
Merge branch 'master' into dev-1674
shunguoy Oct 25, 2023
6977ba3
update the rule #1674
shunguoy Oct 25, 2023
f422915
expand technique title
philljenkins Oct 25, 2023
dd35095
update the rule #1674
shunguoy Oct 25, 2023
2b6839f
rule change #1674
shunguoy Oct 26, 2023
6055ee1
Inline added to help
philljenkins Oct 27, 2023
4ef2326
update the rule #1674
shunguoy Oct 30, 2023
ada4f8e
fix the bound issue #1674
shunguoy Oct 30, 2023
0f5ce36
Merge branch 'master' into dev-1674
philljenkins Oct 30, 2023
8082a50
Add rule set listings
philljenkins Oct 30, 2023
72f38be
Improve readability README-RULES.md
philljenkins Oct 31, 2023
c29fff8
update test cases and rule #1674
shunguoy Oct 31, 2023
4a3ed86
fix the test cases and rules #1674
shunguoy Nov 1, 2023
9f20424
Merge branch 'master' into dev-1674
shunguoy Nov 1, 2023
b81d424
clean up rule #1674
shunguoy Nov 1, 2023
33b8d1f
update the rule #1674
shunguoy Nov 1, 2023
7b22e46
update the rule #1674
shunguoy Nov 1, 2023
98503e2
update messages #1674
shunguoy Nov 1, 2023
c9a6840
change rule messages #1674
shunguoy Nov 1, 2023
7b9eeeb
Remove AAA
philljenkins Nov 2, 2023
4e62307
Merge branch 'master' into dev-1674
philljenkins Nov 2, 2023
dfff012
Update test.yml
shunguoy Nov 2, 2023
5704e27
update the test cases #1674
shunguoy Nov 2, 2023
44da63d
Doc Type added
philljenkins Nov 2, 2023
54a039a
Update .achecker.yml
shunguoy Nov 2, 2023
285d792
intent of requirement
philljenkins Nov 6, 2023
c465adc
do not vs don't
philljenkins Nov 6, 2023
dcc773b
cannot vs can't
philljenkins Nov 6, 2023
af64477
cleanup element_tabbable_unobscured.ts
shunguoy Nov 6, 2023
c73bad5
update bounds calculation #1674
shunguoy Nov 6, 2023
3b72fc8
cleanup the code #1674
shunguoy Nov 6, 2023
778027d
cleanup the code #1674
shunguoy Nov 6, 2023
363100e
editorial
tombrunet Nov 7, 2023
cb092c7
cleanup the code error #1674
shunguoy Nov 7, 2023
a1a263b
Merge branch 'master' into dev-1674
shunguoy Nov 8, 2023
93e38ec
comma
philljenkins Nov 8, 2023
ab13292
Update accessibility-checker-engine/help-v4/en-US/target_spacing_suff…
tombrunet Nov 8, 2023
3a7891f
Update accessibility-checker-engine/src/v4/rules/target_spacing_suffi…
tombrunet Nov 8, 2023
2fd96b8
Published URLs
philljenkins Nov 8, 2023
a7239f5
Merge branch 'master' into dev-1674
shunguoy Nov 9, 2023
c75a765
update the rule definition #1674
shunguoy Nov 9, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add rule set listings
update with rule sets and listing info
philljenkins authored Oct 30, 2023
commit 8082a50e6ac2e9059cc6ec91080825d1c7c9e60b
18 changes: 11 additions & 7 deletions accessibility-checker-engine/README-RULES.md
Original file line number Diff line number Diff line change
@@ -76,10 +76,14 @@ Help integrates the following:
* Element location
* What to do
* Examples
* About the requirement
* Who does this affects?
* About this requirement
* Who does this affect?

Mappings of the latest rules to the standards, the individual failure messages, and `links to the Help files` are listed in the published [Checker rule sets](https://www.ibm.com/able/requirements/checker-rule-sets).
### Rule sets and Mappings

Rule sets such as `IBM Accessibility v7.2`, `WCAG 2.2 (A & AA)`, etc., and mappings of the latest rules to the standards (Requirement and Rule IDs), the individual failure messages (by Reasons ID), and links to the Help files are listed in the published [Checker rule sets](https://www.ibm.com/able/requirements/checker-rule-sets).
`npm run build:help` in the `.../accessibility-checker-engine` directory creates `dist/help/rules.html` that can be reviewed.
Each build creates the `Rules listing` artifact in **Actions** that can be reviewed prior to deployment.

## Test cases

@@ -143,16 +147,16 @@ Note: Rule changes are not automatically rebuilt. You will have to kill the rule

## Summary of steps to implement/update and test a new rule

* Create a rule id for a new rule.
* Create a rule id for a new rule, using the 3-word format with underscores: `type_property_test`.
* Create the help file in [help-v4](help-v4).
* Create the rule implementation in [src/v4/rules](src/v4/rules). The rule implementation includes the rule context, message, help, ruleset mappings, logic and outcome.
* Create the rule implementation in [src/v4/rules](src/v4/rules). The rule implementation includes the rule context, message, help, ruleset mappings, logic, and outcome.
* Create test cases for the rule in [test/v2/checker/accessibility/rules](test/v2/checker/accessibility/rules).
* Test the rules with the test cases. You may run the test cases locally, or run with the local rule server.

## Feedback and reporting bugs

If you think you've found a bug, have questions or suggestions, open a [GitHub Issue](https://github.com/IBMa/equal-access/issues). If you are an IBM employee, feel free to ask questions in the IBM internal Slack channel `#accessibility-at-ibm`.
If you think you've found a bug, or have questions or suggestions, open a [GitHub Issue](https://github.com/IBMa/equal-access/issues). If you are an IBM employee, feel free to ask questions in the IBM internal Slack channel `#accessibility-at-ibm`.

## License

[![IBM Equal Access Toolkit is released under the Apache-2.0 license](https://img.shields.io/badge/license-Apache--2.0-blue.svg)](./LICENSE)
[![IBM Equal Access Toolkit is released under the Apache-2.0 license](https://img.shields.io/badge/license-Apache--2.0-blue.svg)](./LICENSE)