-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(extension): HTML Report CSS and Font Fix #2035 #2049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code changes are fine and I checked that they showed up in the html report.
There are three changes that need to be made:
Two from Jess
- The Current Status card should be purple 20 (see the image sent to you in slack)
- Add a gray 40 outline as shown in the image sent to you in slack.
One from me - Change the order of the "issues found" row icons with numbers in front of them from
Violations, Recommendations, Needs review, Hidden, issues found
to
Violations, Needs review, Recommendations, Hidden, issues found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All requested changes have been made so approved and ready for QA
Validated |
This PR is related to the following issue(s):
Testing reference:
I have conducted the following for this PR: