Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(extension): HTML Report CSS and Font Fix #2035 #2049

Merged
merged 7 commits into from
Sep 19, 2024

Conversation

nam-singh
Copy link
Contributor

@nam-singh nam-singh commented Sep 13, 2024

  • Extension Update Feature

This PR is related to the following issue(s):

Testing reference:

  • Font and css of HTML report should be similar to extension

I have conducted the following for this PR:

  • I validated this code in Chrome and FF
  • I validated this fix in my local env
  • I provided details for testing
  • This PR has been reviewed and is ready for test
  • I understand that the title of this PR will be used for the next release notes.

@nam-singh nam-singh self-assigned this Sep 13, 2024
@nam-singh nam-singh linked an issue Sep 13, 2024 that may be closed by this pull request
Copy link
Contributor

@drjoho drjoho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes are fine and I checked that they showed up in the html report.

There are three changes that need to be made:
Two from Jess

  1. The Current Status card should be purple 20 (see the image sent to you in slack)
  2. Add a gray 40 outline as shown in the image sent to you in slack.
    One from me
  3. Change the order of the "issues found" row icons with numbers in front of them from
    Violations, Recommendations, Needs review, Hidden, issues found
    to
    Violations, Needs review, Recommendations, Hidden, issues found

Copy link
Contributor

@drjoho drjoho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All requested changes have been made so approved and ready for QA

@ErickRenteria
Copy link
Contributor

Validated

@ErickRenteria ErickRenteria merged commit ef801b9 into htmlReportRelease Sep 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML Report Font and CSS Consistency
4 participants