Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync dev branch dev-1974 with the latest #2079

Merged
merged 63 commits into from
Oct 30, 2024
Merged
Changes from 1 commit
Commits
Show all changes
63 commits
Select commit Hold shift + click to select a range
a23e4a8
Code clean up: separate CSSUtil #1974
shunguoy Aug 28, 2024
aa23df8
code cleanup: use ts classes instead of functions #1974
shunguoy Aug 28, 2024
5f93813
refactor the rule code #1974
shunguoy Aug 29, 2024
eeb7eb8
code refactor #1974
shunguoy Aug 30, 2024
0af1efc
code refactor for legacy #1974
shunguoy Aug 30, 2024
1d71d68
create NodeWalker #1974
shunguoy Sep 3, 2024
3b1c30a
refactor rules #1974
shunguoy Sep 9, 2024
cc0c87f
update the rules #1974
shunguoy Sep 10, 2024
87faf20
update the rule engine #1974
shunguoy Sep 10, 2024
18db1dc
add denug for testing #1974
shunguoy Sep 11, 2024
4e27b7b
add debug for testing #1974
shunguoy Sep 12, 2024
2d95642
clear up debug statement #1974
shunguoy Sep 12, 2024
8c513c7
update rules for resolved role #1974
shunguoy Sep 12, 2024
a74a077
update aria definition #1974
shunguoy Sep 12, 2024
521dfdb
update ethe resolvedRole in rules #1974
shunguoy Sep 13, 2024
9b56ace
refactor the rule aria_accessiblename_exists #1974
shunguoy Sep 13, 2024
75ab2a6
add console logs for debugging #1974
shunguoy Sep 13, 2024
6bf3ebd
update the rules #1974
shunguoy Sep 23, 2024
9d1c9a6
refactor isNodeVisible function #1974
shunguoy Sep 24, 2024
7ecf41c
refactor isNodeVisible #1974
shunguoy Sep 24, 2024
570140b
update the role calculation #1974
shunguoy Sep 24, 2024
8b54e0f
update the common util #1974
shunguoy Sep 24, 2024
0eb6a1d
update the aria path which contains presentation #1974
shunguoy Sep 25, 2024
8f27418
update accessible name calculation #1974
shunguoy Sep 26, 2024
041afb7
update the CommonUtil #1974
shunguoy Sep 30, 2024
75ef8e9
update svg and ariaautocomplete calculation #1974
shunguoy Oct 1, 2024
35d136b
update svg rule to use accNameUtil #1974
shunguoy Oct 1, 2024
65cd000
Update AccNameUtil #1974
shunguoy Oct 2, 2024
60ba7a2
update the rules for accessible name calculation #1974
shunguoy Oct 7, 2024
dfb92f0
update accName #1974
shunguoy Oct 7, 2024
2f05f62
update rules to use new Acc name calculation #1974
shunguoy Oct 8, 2024
866d234
update the rule for acc name #1974
shunguoy Oct 9, 2024
daf4473
update the rules to use new acc name calculation #1974
shunguoy Oct 11, 2024
823a48f
update the rules and test cases #1974
shunguoy Oct 21, 2024
3f8f276
update the rules to use accessible name calculation #1974
shunguoy Oct 22, 2024
84429bf
update the rules to use new accessible name #1974
shunguoy Oct 22, 2024
39a7cdd
Merge branch 'master' into dev-1974
shunguoy Oct 22, 2024
1976f5a
fix merge error #1974
shunguoy Oct 22, 2024
83d3815
fix the baselines #1974
shunguoy Oct 23, 2024
ab5dba4
update the selenium baselines #1974
shunguoy Oct 23, 2024
1915b30
Update JSONObjectStructureVerification.html.json
shunguoy Oct 23, 2024
257b361
Update JSONObjectStructureVerificationSelenium.html.json
shunguoy Oct 23, 2024
a7ba755
Update violations.json
shunguoy Oct 23, 2024
a10faa0
Update DOMWalker.ts
shunguoy Oct 23, 2024
712c8d2
fix the error "TypeError: Cannot read properties of null (reading 'no…
shunguoy Oct 24, 2024
ffee74b
Update label_name_visible.ts
shunguoy Oct 24, 2024
c51b995
update target spacing rule #1974
shunguoy Oct 25, 2024
796c3a8
update spaing rule #1974
shunguoy Oct 28, 2024
a19aa48
update DOMWalker #1974
shunguoy Oct 28, 2024
007d3f8
recalculate the inline text status #1974
shunguoy Oct 28, 2024
d73916d
update spacing rule and test results #1974
shunguoy Oct 29, 2024
404f4ba
Merge branch 'master' into dev-1974
shunguoy Oct 29, 2024
3950622
clean up the code #1974
shunguoy Oct 29, 2024
205a8bf
fix the baseline #1974
shunguoy Oct 29, 2024
d2ededb
update the baseline #1974
shunguoy Oct 29, 2024
61dbea8
update the baselines #1974
shunguoy Oct 29, 2024
3c26137
update puppeteer test skip file list #1974
shunguoy Oct 29, 2024
75aa8f2
update ignored test files #1974
shunguoy Oct 29, 2024
98aad61
skip 3 test files #1974
shunguoy Oct 29, 2024
613eedc
skip three test files in java test #1974
shunguoy Oct 29, 2024
b76c8ad
java test file update #1974
shunguoy Oct 29, 2024
50e83b5
Update AccessibilityCheckerSeleniumFFTest.java
shunguoy Oct 29, 2024
db30dfd
clean up the code #1974
shunguoy Oct 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clear up debug statement #1974
  • Loading branch information
shunguoy committed Sep 12, 2024
commit 2d956422def0a1f51a7a25c044a0bfaf1f4a64d8
Original file line number Diff line number Diff line change
@@ -76,14 +76,14 @@ export const text_block_heading: Rule = {
let wordStr: string[] = [];
let emphasizedText = false;
//let nw = new NodeWalker(ruleContext);
let nw = new DOMWalker(ruleContext);
let nw = new DOMWalker(ruleContext);nw.nextNode();
let passed = false;
while (!passed &&
nw.nextNode() &&
nw.node !== ruleContext &&
nw.node !== DOMWalker.parentNode(ruleContext) &&
!["br", "div", "p"].includes(nw.node.nodeName.toLowerCase())) // Don't report twice
{
{
if (nw.node === ruleContext || CommonUtil.shouldNodeBeSkippedHidden(nw.node))
continue;