Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #644

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Develop #644

merged 4 commits into from
Oct 30, 2024

Conversation

stephanmg
Copy link
Collaborator

Fix pip deployment.

stephanmg and others added 3 commits October 29, 2024 16:01
@stephanmg
Update deploy.yml
34bd3cf
@arrjon
Merge branch 'main' into develop
634efa1
@stephanmg
Update deploy.yml (#643)
1d75532 
* Update deploy.yml

Upgrade actions/checkout@v2 -> actions/checkout@v4.

* Update deploy.yml

According to docs username must be __token__ when using API token: https://pypi.org/help/#invalid-auth

* Update deploy.yml

We need to generate PYP_API_TOKEN once we have access. 
__token__ is required, since we do authenticate with an API token and not username password combination.
@stephanmg stephanmg self-assigned this Oct 30, 2024
@stephanmg stephanmg requested a review from arrjon October 30, 2024 09:16
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.06%. Comparing base (077c8e8) to head (0518876).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #644      +/-   ##
==========================================
- Coverage   84.29%   84.06%   -0.24%     
==========================================
  Files         141      139       -2     
  Lines        8544     8514      -30     
==========================================
- Hits         7202     7157      -45     
- Misses       1342     1357      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arrjon
arrjon approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@arrjon arrjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephanmg stephanmg merged commit 6ee268f into main Oct 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arrjon arrjon arrjon approved these changes

Assignees

@stephanmg stephanmg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephanmg @codecov-commenter @arrjon