Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icoscp - fix getIdList() #198

Merged
merged 3 commits into from
Oct 11, 2024
Merged

icoscp - fix getIdList() #198

merged 3 commits into from
Oct 11, 2024

Conversation

ZogopZ
Copy link
Member

@ZogopZ ZogopZ commented Oct 10, 2024 •
edited
Loading

See #194 for more information.

@ZogopZ ZogopZ added fix Fix something that is not working as intended icoscp labels Oct 10, 2024
@ZogopZ ZogopZ requested a review from ukarst October 10, 2024 14:38
@ZogopZ ZogopZ self-assigned this Oct 10, 2024
@ZogopZ ZogopZ linked an issue Oct 10, 2024 that may be closed by this pull request
Error with station.get #194
Closed
ukarst
ukarst approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@ukarst ukarst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

station.getIdList() and station.get() work again for all stations except IE-Cra.
For IE-Cra station.get() returns an error.
For this station icoscp_core doesn't return data as well (as far as I could find).

@ZogopZ ZogopZ merged commit 20960ab into master Oct 11, 2024
3 checks passed
@ZogopZ ZogopZ deleted the 194-fix-station-getIdList branch October 11, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukarst ukarst ukarst approved these changes

Assignees

@ZogopZ ZogopZ

Labels
fix Fix something that is not working as intended icoscp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with station.get
3 participants
@ZogopZ @ukarst @mirzov