Fixed Vulnerabilities pointed out by Sonarqube analysis

ICOnator · Feb 7, 2019 · 1cbdcbd · 1cbdcbd
1 parent 00de4cc
commit 1cbdcbd
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/services/monitor/src/main/java/io/iconator/monitor/config/MonitorBean.java b/services/monitor/src/main/java/io/iconator/monitor/config/MonitorBean.java
@@ -79,7 +79,9 @@ public SPVBlockStore blockStore(NetworkParameters chainNetworkParameters)
         File blockStoreFile = Files.createTempFile("chain", "tmp").toFile();
         blockStoreFile.deleteOnExit();
         if (blockStoreFile.exists()) {
-            blockStoreFile.delete();
+            if(!blockStoreFile.delete()){
+                throw new RuntimeException("File not deleted successfully. " + blockStoreFile.getName());
+            }
         }
         return new SPVBlockStore(chainNetworkParameters, blockStoreFile);
     }

diff --git a/services/rates/src/main/java/io/iconator/rates/service/BlockchainInfoService.java b/services/rates/src/main/java/io/iconator/rates/service/BlockchainInfoService.java
@@ -28,8 +28,8 @@ public class BlockchainInfoService {
     private final static Logger LOG = LoggerFactory.getLogger(BlockchainInfoService.class);
 
 
-    public static String TEST_URL = "https://testnet.blockchain.info/latestblock";
-    public static String MAIN_URL = "https://blockchain.info/latestblock";
+    public final static String TEST_URL = "https://testnet.blockchain.info/latestblock";
+    public final static String MAIN_URL = "https://blockchain.info/latestblock";
 
     @Autowired
     private RatesAppConfigHolder ratesAppConfig;

diff --git a/services/rates/src/main/java/io/iconator/rates/service/EtherscanService.java b/services/rates/src/main/java/io/iconator/rates/service/EtherscanService.java
@@ -26,7 +26,7 @@ public class EtherscanService {
 
     private final static Logger LOG = LoggerFactory.getLogger(EtherscanService.class);
 
-    public static String URL = "https://{ethnet}.etherscan.io/api?module=proxy&action=eth_blockNumber&apikey={ethkey}";
+    public final static String URL = "https://{ethnet}.etherscan.io/api?module=proxy&action=eth_blockNumber&apikey={ethkey}";
 
     @Autowired
     private RatesAppConfigHolder ratesAppConfig;