Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix singular for "canoes" #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix singular for "canoes" #30

wants to merge 1 commit into from

Conversation

timkelty
Copy link

No description provided.

@olvlvl
Copy link
Member

olvlvl commented Dec 1, 2018 •
edited
Loading

Hi @timkelty, thanks for the patch. Do you mind defining this using ->irregular()? It does't look like a rule that can be applied to many things, and it's breaking volcano:

-'volcano'
+'volcanoe'

Also, please add it to the test cases.

@timkelty
Copy link
Author

timkelty commented Dec 3, 2018 •
edited
Loading

@olvlvl there are a few others (I think shoe is already in there):

toes
canoes
(snow|horse)shoes
woes
foes
hoes
does (as in multiple female deer)
schmoes 😆

@olvlvl
Copy link
Member

olvlvl commented Dec 3, 2018 •
edited
Loading

I'm reading this article: https://en.wikipedia.org/wiki/English_plurals and it seems adding -es to word ending with o should be the default inflection. Adding only -s is for Italian stuff such as piano. English is so complicated :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timkelty @olvlvl