add teleop controller #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 30, 2024 14:05
(from https://github.com/tpoignonec/passive_vic_teleop_ros2 / commit SHA = de3d28f0d4564299251f8d38f36908fe1d762b5c)
tpoignonec
added
enhancement
Test Results667 tests +105 452 ✅ +93 0s ⏱️ -1s For more details on these failures, see this check. Results for commit ee5887d. ± Comparison against base commit 2c330d6. This pull request removes 36 and adds 141 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
mergify bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
* import teleoperation msgs * import and refractor teleoperation controller (from https://github.com/tpoignonec/passive_vic_teleop_ros2 / commit SHA = de3d28f0d4564299251f8d38f36908fe1d762b5c) * fix teleop controller name * fix rule plugin export * remove testing for now * misc fixes * #IF guard for humble * fix deps * comment out humble-specific code (cherry picked from commit 5d12107)
tpoignonec
added a commit
that referenced
this pull request
Aug 30, 2024
* add teleop controller (#35) * import teleoperation msgs * import and refractor teleoperation controller (from https://github.com/tpoignonec/passive_vic_teleop_ros2 / commit SHA = de3d28f0d4564299251f8d38f36908fe1d762b5c) * fix teleop controller name * fix rule plugin export * remove testing for now * misc fixes * #IF guard for humble * fix deps * comment out humble-specific code (cherry picked from commit 5d12107) * reintroduce humble specific precautions in teleop ctrl --------- Co-authored-by: Thibault Poignonec <[email protected]> Co-authored-by: Thibault Poignonec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import cartesian VIC-based teleoperation controller from https://github.com/tpoignonec/passive_vic_teleop_ros2 and proceed to major refractoring.