Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair erroneous units for material_holdup in CV0D when mass basis defined #1460

Merged
merged 14 commits into from
Aug 16, 2024
Merged

Repair erroneous units for material_holdup in CV0D when mass basis defined #1460

merged 14 commits into from
Aug 16, 2024

Commits on Jul 30, 2024

  1. repair erroneous units for material_holdup when mass basis defined; a… 

    …dd tests
    @adam-a-a
    adam-a-a committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    787a38e View commit details
    Browse the repository at this point in the history

  2. blk

    @adam-a-a
    adam-a-a committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    5a49dbb View commit details
    Browse the repository at this point in the history

  3. add holdup_units = None

    @adam-a-a
    adam-a-a committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1e4b870 View commit details
    Browse the repository at this point in the history

  4. condense changes under has_holdup conditional and only add the change… 

    … needed for mass flow, preserving all previous use cases
    @adam-a-a
    adam-a-a committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    5e53261 View commit details
    Browse the repository at this point in the history

  5. blk

    @adam-a-a
    adam-a-a committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    cc1db7d View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. double-check 1d and cover other conditional for holdup units in 0d CV

    @adam-a-a
    adam-a-a committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    ed6bb0e View commit details
    Browse the repository at this point in the history

  2. resolve unit inconsistency when other material flow basis specified a… 

    …nd test
    @adam-a-a
    adam-a-a committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    5513210 View commit details
    Browse the repository at this point in the history

  3. fix a couple of typos in flowsheet_model

    @adam-a-a
    adam-a-a committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    0593cf2 View commit details
    Browse the repository at this point in the history

  4. scale the new vars on _physicalparameterblock

    @adam-a-a
    adam-a-a committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    422bf87 View commit details
    Browse the repository at this point in the history

  5. blk

    @adam-a-a
    adam-a-a committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    a81e95a View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. remove mods related to other mass flow basis

    @adam-a-a
    adam-a-a committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    30b664b View commit details
    Browse the repository at this point in the history

  2. cleanup

    @adam-a-a
    adam-a-a committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    a147ee5 View commit details
    Browse the repository at this point in the history

  3. add 1d test to check dynamic with mass flow basis as well as unit con… 

    …sistency
    @adam-a-a
    adam-a-a committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    8cca3f3 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Merge branch 'main' into dynamic_cv0d

    @andrewlee94
    andrewlee94 authored Aug 16, 2024
    Configuration menu
    Copy the full SHA
    8e2450c View commit details
    Browse the repository at this point in the history