-
Notifications
You must be signed in to change notification settings - Fork 228
TODOs Ideas for Modular Properties 2.0
dallan-keylogic edited this page Sep 5, 2024
·
4 revisions
This is a page in order to gather thoughts about how a future version of the modular property framework should be organized, especially if the changes required would require a fundamental rewrite to implement. This page does not imply that such a rewrite is going to happen in the near future.
- Consider implementing separate EoS objects that are then used by phase objects, instead of the current paradigm in which an EoS is created for each phase. This change would make checking that the same EoS and EoS options are used by both phases easier for situations in which that's desirable, such as fluids that may be supercritical.
- Rethink phase equilibrium for phases with inherent reactions, especially during initialization.
- Log fugacity, log saturation pressure, and log equilibrium constants should be the default.
- We should be able to provide a correlation for a property or log property, like, for example, log viscosity, and have it generate the log/non-log from the correlation provided. Presently, we don't have log properties for a number of properties.
- ..?
- Set up pre-commit
- Run pytest with coverage report
- Run Pylint locally
- Update the Pyomo version
- Install Pyomo from a local Git clone
- Set up GitHub authentication with GCM
- Handle warnings in pytest