-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Survey dialog on Structured Menu #8406
base: master
Are you sure you want to change the base?
Conversation
@rdstern please could you test before I review (i.e. our normal process)? thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just note the trivial point that on the Structured menu we could add the ... to indicate we will load a dialog.
Then I need @lilyclements to test this one. I am not up to the different options.
@lilyclements can you test this? |
@MeSophie I am immediately getting errors, and so before I test this any further, have you tested this? I suspect the issue is in the ID control. Is this meant to be a ucrReceiver or a ucrInput? The design looks really nice and neatly laid out, so really good job there. But I can't seem to line it up with the design specified in #6718 (one example is that the "weights" receiver is on the SRS tab here but not in #6718). Were these diversions discussed somewhere on GitHub so I can check the design lines up? Thanks. |
@lilyclements I have tested the dialog before. ID is a input for SRS, and Stratified and Received for Cluster according to what I understand from R package. Maybe I am wrong. And for the difference between the new design and the one in #6718 I didn't discuss about it. I added weight in SRS method also according to parameters using by |
@MeSophie Thanks for this explanation. I think before going further with a review I want to check I am comparing this design to the correct "finalised" design discussed. |
@lilyclements sorry, I don't know of a discussion on a changed design. |
Fixes partially #6718
@lilyclements, @lloyddewit I have added Survey dialog on Structured menu. This replace PR #8258. Please have a look.