Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Survey dialog on Structured Menu #8406

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

MeSophie
Copy link
Contributor

Fixes partially #6718

@lilyclements, @lloyddewit I have added Survey dialog on Structured menu. This replace PR #8258. Please have a look.

@lloyddewit
Copy link
Contributor

@rdstern please could you test before I review (i.e. our normal process)? thanks

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just note the trivial point that on the Structured menu we could add the ... to indicate we will load a dialog.
Then I need @lilyclements to test this one. I am not up to the different options.

@N-thony
Copy link
Collaborator

N-thony commented Jul 6, 2023

I just note the trivial point that on the Structured menu we could add the ... to indicate we will load a dialog. Then I need @lilyclements to test this one. I am not up to the different options.

@lilyclements can you test this?

@lilyclements
Copy link
Contributor

@MeSophie I am immediately getting errors, and so before I test this any further, have you tested this? I suspect the issue is in the ID control. Is this meant to be a ucrReceiver or a ucrInput?

The design looks really nice and neatly laid out, so really good job there. But I can't seem to line it up with the design specified in #6718 (one example is that the "weights" receiver is on the SRS tab here but not in #6718). Were these diversions discussed somewhere on GitHub so I can check the design lines up?

Thanks.

@MeSophie
Copy link
Contributor Author

@lilyclements I have tested the dialog before. ID is a input for SRS, and Stratified and Received for Cluster according to what I understand from R package. Maybe I am wrong.

image

And for the difference between the new design and the one in #6718 I didn't discuss about it. I added weight in SRS method also according to parameters using by svydesign function. I couldn't discuss more about this design because @HawardKetoyoMsatsi is not longer in the team.

@lilyclements
Copy link
Contributor

@MeSophie Thanks for this explanation. I think before going further with a review I want to check I am comparing this design to the correct "finalised" design discussed.
@rdstern do you know if there were discussions on the design to change it from #6718 to a different layout? If so, do you know where these discussions took place?

@rdstern
Copy link
Collaborator

rdstern commented Jul 25, 2023

@lilyclements sorry, I don't know of a discussion on a changed design.

@lilyclements
Copy link
Contributor

@rdstern great thanks. In which case @MeSophie can you change the design here to be consistent with issue #6718

@N-thony
Copy link
Collaborator

N-thony commented Sep 18, 2023

@rdstern great thanks. In which case @MeSophie can you change the design here to be consistent with issue #6718

@MeSophie any progress?

@N-thony
Copy link
Collaborator

N-thony commented Nov 13, 2023

@rdstern great thanks. In which case @MeSophie can you change the design here to be consistent with issue #6718

@MeSophie any progress?

@MeSophie how is it going here?

@MeSophie MeSophie marked this pull request as draft January 17, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants